Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODOs from ES-8334 #108695

Merged
merged 1 commit into from
May 16, 2024

Conversation

DaveCTurner
Copy link
Contributor

Upon further discussion we decided not to do any of these things, so
this commit removes the leftover TODO comments.

Upon further discussion we decided not to do any of these things, so
this commit removes the leftover TODO comments.
@DaveCTurner DaveCTurner added >non-issue :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.15.0 labels May 15, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner merged commit 0247199 into elastic:main May 16, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/05/15/finish-ES-8334 branch May 16, 2024 06:50
nicktindall pushed a commit to nicktindall/elasticsearch that referenced this pull request May 17, 2024
Upon further discussion we decided not to do any of these things, so
this commit removes the leftover TODO comments.
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 17, 2024
Upon further discussion we decided not to do any of these things, so
this commit removes the leftover TODO comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >non-issue Team:Distributed Meta label for distributed team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants