Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate server unit tests to use MockLogAppender.capture #108698

Merged
merged 2 commits into from
May 16, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 15, 2024

relates #108526

@rjernst rjernst added >test Issues or PRs that are addressing/adding tests :Core/Infra/Logging Log management and logging utilities labels May 15, 2024
@rjernst rjernst requested a review from a team May 15, 2024 23:34
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Core/Infra Meta label for core/infra team labels May 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjernst rjernst merged commit 240f2be into elastic:main May 16, 2024
15 checks passed
@rjernst rjernst deleted the test/mock_appender_try3 branch May 16, 2024 13:35
nicktindall pushed a commit to nicktindall/elasticsearch that referenced this pull request May 17, 2024
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants