Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setTitleBarOverlay should be implemented on BaseWindow #42150

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: setTitleBarOverlay should be implemented on BaseWindow #42150

merged 1 commit into from
May 23, 2024
+62 −71

Conversation

codebytere
Copy link
Member

Backport of #41960.

See that PR for details.

Notes: Fixed an issue where setTitleBarOverlay didn't work as expected when called on BaseWindow.

@codebytere codebytere requested a review from a team May 13, 2024 19:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 13, 2024
@trop trop bot mentioned this pull request May 13, 2024
Merged
3 tasks
@trop trop bot added 31-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 13, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 13, 2024
@codebytere codebytere requested a review from a team as a code owner May 13, 2024 19:51
@codebytere codebytere force-pushed the set-titlebar-base-window-31 branch from 114f64d to 3d6e6d2 Compare May 17, 2024 09:05
@codebytere codebytere merged commit 31a753f into 31-x-y May 23, 2024
13 checks passed
@codebytere codebytere deleted the set-titlebar-base-window-31 branch May 23, 2024 09:08
@release-clerk Release Clerk
Copy link

release-clerk bot commented May 23, 2024

Release Notes Persisted

Fixed an issue where setTitleBarOverlay didn't work as expected when called on BaseWindow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
31-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @VerteDinde