feat: expose system preferences to utility process #42203
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgexu99
changed the title
lib/utility/api/module-list.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| // Utility side modules, please sort alphabetically. | |||
| export const utilityNodeModuleList: ElectronInternal.ModuleEntry[] = [ | |||
| { name: 'net', loader: () => require('./net') } | |||
| { name: 'net', loader: () => require('./net') }, | |||
| { name: 'systemPreferences', loader: () => require('./system-preferences') } | |||
There was a problem hiding this comment.
Can we just map this to the @browser file? no need to copy paste the impl I think
There was a problem hiding this comment.
done- uses @electron/internal/browser/api/system-preferences now. However, the net module and some others all re-copy: any insights as to why we chose to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables
systemPreferencesto be used within a utility process fork and not only the main process.Motive
systemPreferences.getMediaAccessStatusonly returns accurate permissions-states at the start of a user's session, but may not reflect permission changes made to the app until the app full quits/restarts. This can lead to silent failures when we attempt to access a device when the permissions have been revoked mid-session.Being able to call this function from within the Utility Module will allow for accurate permission state retrieval.
Testing
[x] added test
[x] manually verified change with gist
Release Notes
Notes: expose
systemPreferencestoutilityProcess