-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for elementor.settings.page in isScrollSnapActive [ED-14910] #27353
Open
m1ga
wants to merge
14
commits into
elementor:main
Choose a base branch
from
m1ga:fixScrollSnappError
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Benlola wrong place to post this. This is a PR and not related to the |
nicholaszein
changed the title
fix: check for elementor.settings.page in isScrollSnapActive
fix: check for elementor.settings.page in isScrollSnapActive [ED-14910]
May 22, 2024
nicholaszein
added
bug
Indicates a bug with one or multiple components.
editor/site-settings
References any component related to the Editor Site Settings.
component/code
Indicates when a topic is related to a component’s code.
document/settings
References a Document's (Posts, Pages, Templates, Popups, etc.) settings.
labels
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Indicates a bug with one or multiple components.
component/code
Indicates when a topic is related to a component’s code.
document/settings
References a Document's (Posts, Pages, Templates, Popups, etc.) settings.
editor/site-settings
References any component related to the Editor Site Settings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Fixes: #19345
Uncaught TypeError: elementor.settings.page is undefined
when trying to open the Elementor EditorDescription
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #