Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for elementor.settings.page in isScrollSnapActive [ED-14910] #27353

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

m1ga
Copy link

@m1ga m1ga commented May 16, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Fixes: #19345

Uncaught TypeError: elementor.settings.page is undefined when trying to open the Elementor Editor

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

@Benlola
Copy link

Benlola commented May 17, 2024

image
Only Elementor, Elementor Pro and Hello Elementor Theme, no possibility to edit something is give error: "Uncaught TypeError: e.O is not a function"

@m1ga
Copy link
Author

m1ga commented May 17, 2024

@Benlola wrong place to post this. This is a PR and not related to the e.O is not a function issue.

@nicholaszein nicholaszein changed the title fix: check for elementor.settings.page in isScrollSnapActive fix: check for elementor.settings.page in isScrollSnapActive [ED-14910] May 22, 2024
@nicholaszein nicholaszein added bug Indicates a bug with one or multiple components. editor/site-settings References any component related to the Editor Site Settings. component/code Indicates when a topic is related to a component’s code. document/settings References a Document's (Posts, Pages, Templates, Popups, etc.) settings. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components. component/code Indicates when a topic is related to a component’s code. document/settings References a Document's (Posts, Pages, Templates, Popups, etc.) settings. editor/site-settings References any component related to the Editor Site Settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔃 🐞 Bug report: Uncaught TypeError: elementor.settings.page is undefined (PR #27353) - [ED-14910]
4 participants