Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete read_entry_data method from class ComponentCatalogConnector #3141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Mar 30, 2023

Closes #2514

What changes were proposed in this pull request?

How was this pull request tested?

  1. Installed https://github.com/ptitzler/examples/tree/main/component-catalog-connectors/kfp-example-components-connector, which only implements the obsolete method. (elyra-examples-kfp-catalog==0.1.0)
  2. Created an instance of that catalog connector in Elyra.
  3. Confirmed that the expected error is logged.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added component:catalog connectors Access to component catalogs impact:breaking change Delivery introduces a change that is not backward compatible labels Mar 30, 2023
@ptitzler ptitzler added this to the 4.0.0 milestone Mar 30, 2023
@ptitzler ptitzler added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Mar 30, 2023
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take these changes for a spin, but they look good. Thanks @ptitzler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:catalog connectors Access to component catalogs impact:breaking change Delivery introduces a change that is not backward compatible status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for the read_catalog_entry method for component catalog connectors
2 participants