Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image crate to 0.25 #4160

Merged
merged 4 commits into from May 13, 2024
Merged

Update image crate to 0.25 #4160

merged 4 commits into from May 13, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 11, 2024

To not produce duplicating deps in Rerun (rerun-io/rerun#5280) I suggest we wait with merging this until these crates have updated to image 0.25:

@emilk emilk added eframe Relates to epi and eframe dependencies Pull requests that update a dependency file egui_extras labels Mar 11, 2024
@emilk emilk marked this pull request as draft March 11, 2024 19:30
@emilk emilk mentioned this pull request Mar 11, 2024
7 tasks
@oscargus
Copy link
Contributor

There are some comments in code and README:s that one may want to update as well.

@torokati44
Copy link
Contributor

Meanwhile, over at Ruffle we jumped the gun with ruffle-rs/ruffle#15634, causing a missing logo image...: :/
image

@torokati44
Copy link
Contributor

Both of the downstream PRs have been merged now, so this now only has to wait for a new release of each crate to be published.

@torokati44
Copy link
Contributor

arboard v3.4.0 is now out.

@torokati44
Copy link
Contributor

Referencing: gltf-rs/gltf#420

@torokati44
Copy link
Contributor

And gltf v1.4.1 is out! 🎉

@torokati44
Copy link
Contributor

Is there anything I could do to help getting this in (and a new release with it out), or is it just a matter of time to actually do it?

@emilk emilk marked this pull request as ready for review May 13, 2024 11:21
@emilk emilk merged commit 44d65f4 into master May 13, 2024
35 checks passed
@emilk emilk deleted the emilk/update-image branch May 13, 2024 11:35
@emilk
Copy link
Owner Author

emilk commented May 13, 2024

A new release of the egui crates won't happen for another few weeks

@torokati44
Copy link
Contributor

Thank you for the merge! That's fine, we can wait.

@jazzay
Copy link

jazzay commented May 19, 2024

@emilk since this upgrade some of my jpeg images are no longer loading properly. I suspect it is this bug in image/upstream, as they changed jpeg decoders in 0.25:

Certain JPEGs cause assertion failure in zune-jpeg

Is it possible to downgrade for now?

UPDATE: Ok after updating my own crates to 0.25.1 it appears to be working ok. Apologize for the false alarm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe egui_extras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants