Removed all parts related to runtime guard - https://github.com/envoy… #34199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldradware
force-pushed
the
remove-runtime-guard-33627
branch
from
c642081
to
deda219
Compare
adisuissa
reviewed
May 16, 2024
|
/wait |
danieldradware
force-pushed
the
remove-runtime-guard-33627
branch
from
a56e630
to
866cd3d
Compare
adisuissa
reviewed
May 20, 2024
| @@ -330,10 +329,6 @@ absl::string_view ExtractorImpl::extractJWT(absl::string_view value_str, | |||
| } | |||
|
|
|||
| // There should be two dots (periods; 0x2e) inside the string, but we don't verify that here | |||
| if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.token_passed_entirely")) { | |||
| return value_str.substr(starting); | |||
There was a problem hiding this comment.
Sorry, I don't get something fundamental in this PR.
In #28678 you introduced a feature, and added a runtime-guard around it, so that if one wants to temporarily disable it, they can.
This PR, IIUC, is removing the implementation that was added (reverting the previous PR). Why is that?
There was a problem hiding this comment.
Yes! you're right I missed it that runtime guard is by default enabled.
Now I fixed it and now it will always run my change.
Till now code is cutting the valid token and from now always pass it as is.
Thanks for your important comment!
danieldradware
force-pushed
the
remove-runtime-guard-33627
branch
from
b68a517
to
7692a42
Compare
Signed-off-by: Daniel Danan <danield@radware.com>
…work with my changes (without runtime guard) + returned a comment to extractor.cc Signed-off-by: Daniel Danan <danield@radware.com>
Signed-off-by: Daniel Danan <danield@radware.com>
Signed-off-by: Daniel Danan <danield@radware.com>
danieldradware
force-pushed
the
remove-runtime-guard-33627
branch
from
48bd678
to
6e88fcd
Compare
|
Added to release notes |
adisuissa
reviewed
May 22, 2024
Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: danieldradware <117576776+danieldradware@users.noreply.github.com>
|
@zuercher for senior stamp |
zuercher
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…proxy/envoy/issues/33627
Commit Message:
Removed all parts related to runtime guard
Additional Description:
As Envoy team asked from me to remove all relevant parts of runtime guard (#33627)
In this PR I removed it.
Risk Level:
Testing:
Removed tests
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]