Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[max7219digit] support flip_x when rotate_chip is 90° or 270° #6109

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Tugzrida
Copy link

@Tugzrida Tugzrida commented Jan 17, 2024

What does this implement/fix?

The flip_x option of max7219digit was only implemented when rotate_chip was 0 or 180. This adds the implementation for 90 and 270. I've tested all 8 combinations of flip_x and rotate_chip locally and they work as expected.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): none found

Pull request in esphome-docs with documentation (if applicable): n/a

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
spi:
  clk_pin: GPIO7
  mosi_pin: GPIO6

display:
  - platform: max7219digit
    cs_pin: GPIO5
    num_chips: 5
    reverse_enable: true
    flip_x: true
    rotate_chip: 270
    lambda: |-
        it.printdigit("12345");

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @rspaargaren, mind taking a look at this pull request as it has been labeled with an integration (max7219digit) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (4d8b5ed) to head (58893de).
Report is 603 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6109      +/-   ##
==========================================
+ Coverage   53.70%   54.21%   +0.50%     
==========================================
  Files          50       50              
  Lines        9408     9594     +186     
  Branches     1654     1691      +37     
==========================================
+ Hits         5053     5201     +148     
- Misses       4056     4069      +13     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants