[max7219digit] support flip_x
when rotate_chip
is 90° or 270°
#6109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The
flip_x
option ofmax7219digit
was only implemented whenrotate_chip
was 0 or 180. This adds the implementation for 90 and 270. I've tested all 8 combinations offlip_x
androtate_chip
locally and they work as expected.Types of changes
Related issue or feature (if applicable): none found
Pull request in esphome-docs with documentation (if applicable): n/a
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: