New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proceed if AP mode is set up #6631
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6631 +/- ##
==========================================
+ Coverage 53.70% 54.05% +0.34%
==========================================
Files 50 50
Lines 9408 9554 +146
Branches 1654 1687 +33
==========================================
+ Hits 5053 5164 +111
- Misses 4056 4066 +10
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
No success. See attached. |
Try again. I've tested this one and it works. |
Thanks for yor effort. This version indeed seems to start the web server properly with or without STA-wifi presence. BUT strangely enough I found one sequence that does not now work: The strangest part is that if the device is started with STA-wifi available, i.e AP is not started before STA-wifi is connected, it will start AP when STA-wifi is lost. I tested with esphome 2024.4.1 + pr#6631, but I can't see anything in 2024.4.2 changelog that could affect this. |
What happens in that scenario without this change? |
As you apparently suspected, the same happens also with pure 2024.4.1. (exept of course web server starts only when STA-wifi is connected) |
What does this implement/fix?
If wifi is configured but can't connect and the AP comes up, the web server and other services are not available.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#3956
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: