-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modem] pppos tcp/ip for uart modem (esp-idf only) #6721
base: dev
Are you sure you want to change the base?
Conversation
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6721 +/- ##
==========================================
+ Coverage 53.70% 54.13% +0.42%
==========================================
Files 50 50
Lines 9408 9619 +211
Branches 1654 1698 +44
==========================================
+ Hits 5053 5207 +154
- Misses 4056 4086 +30
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
oups, initial bad branch push, This is a currently a draft PR, it needs more works. It is currently tested and developed on Lilygo T-SIM7600E. It use esp-modem, so it's I've been able to use There is some modem initialisation that need to be fixed. For now, it's better to start the device from a cold state (with no power). The PPPos data communication is done in CMUX mode, so it should be possible to send other AT command (gnss, gps, etc...) using the command channel (TODO). And I'm sot sure that pppos:
platform: cellular
...
gps:
platform: cellular |
I can test this with an A7670G if that helps. |
What does this implement/fix?
This implement pppos tcp/ip for esp32. it conflict with
wifi
orethernet
component.Types of changes
Related issue or feature (if applicable):
esphome/feature-requests#2303
esphome/feature-requests#477
esphome/feature-requests#1379
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: