Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Phi-2 #410

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Support Phi-2 #410

wants to merge 7 commits into from

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jan 6, 2024 •
edited

Description

Add support for Phi-2.

Corresponding documentation PR

TBD

Types of change

New feature.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added feat/new New feature feat/model Feature: models labels Jan 6, 2024
@rmitsch rmitsch self-assigned this Jan 6, 2024
@rmitsch rmitsch changed the base branch from main to develop January 6, 2024 10:30
@rmitsch rmitsch added the Test GPU Run GPU tests label Jan 6, 2024
@rmitsch rmitsch marked this pull request as ready for review January 19, 2024 15:55
@rmitsch rmitsch marked this pull request as draft January 19, 2024 15:55
svlandeg
svlandeg reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not comfortable merging something we can't test :/

@rmitsch rmitsch changed the title Support Phi-2 and (untested) Mixtral Support Phi-2 Feb 7, 2024
@rmitsch rmitsch changed the base branch from develop to main February 7, 2024 08:53
@rmitsch
Copy link
Collaborator Author

rmitsch commented Feb 7, 2024 •
edited

Removed Mixtral. Will update this and add a doc PR after #428 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees

@rmitsch rmitsch

Labels
feat/model Feature: models feat/new New feature Test GPU Run GPU tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmitsch @svlandeg