[dev-launcher][Android] Fixed LogBox isn't working on the new architecture

[lukmccall]

Why

Closes ENG-12206.

How

It appears that the LogBox surface does not detach when the app reloads. This behavior is likely normal, but it causes issues with the developer menu. To address this, I have temporarily implemented a solution to detach the surface when the root view is destroyed.

I'll try to investigate what is a default for RN apps and why it doesn't work with the menu. However, for now, that fix should be enough.

Test Plan

• new app with new architecture enable ✅

[linear]

ENG-12206 Logbox not working with new arch in expo-dev-client on Android

[expo-bot]

The Pull Request introduced fingerprint changes against the base commit: ae73d5b

Fingerprint diff

[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-launcher",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "0b359a1e901e9a05469fcf62f2687026359aaa72"
  }
]

---

Generated by PR labeler 🤖

[Kudo]

could the issue relate to facebook/react-native#44393?

also if we want to customize something in our DevSupportManager, i would recommend to do it in DevLauncherBridgelessDevSupportManager than NonFinalBridgelessDevSupportManager. that would help the future react-native upgrade easier. (we would know which part is our customized and which part is just copied)

[lukmccall]

could the issue relate to facebook/react-native#44393?

I think it's. Let me test that ;)
I'm still considering merging my PR as it is. I don't want to wait for Meta 😅
I agree that making changes within DevLauncherBridgelessDevSupportManager would be more correct, but since it's just a temporary fix, I don't think it's necessary. I'll probably revert that when your PR lands.

[Kudo]

cool, let's keep it as-is. thanks for helping that.