Call object_from_json from decoder when issubclass(_class, SerializationMixin) #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…ionMixin) Summary: As titled. This solves a relatively common problem (which may crop up again in some recently planning changes) in which the init args of some serializable Ax object is itself a serializable Ax object Differential Revision: D56356035
mpolson64
force-pushed
the
export-D56356035
branch
from
f3f8025
to
fca9c15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56356035 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 496 496
Lines 48188 48188
=======================================
Hits 45935 45935
Misses 2253 2253 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. This solves a relatively common problem (which may crop up again in some recently planning changes) in which the init args of some serializable Ax object is itself a serializable Ax object
Differential Revision: D56356035