Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI upgrade to Node 22 #10119

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: CI upgrade to Node 22 #10119

wants to merge 6 commits into from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 9, 2024

Motivation

CI should use Node 20/LTS by default

Matrix strategies should use Node versions 18.0, 20, 22


Note Node v22 behavior regarding Intl.DisplayNames is more "strict" than v18/20 (throws more often). I had to adjust the code accordingly. Not sure if it's a bug or if they follow the spec more accurately.


Note TSC has a segmentation fault under Node 22. Apparently, this is related to a V8 maglev bug:

Upgrading to TS 5.5 beta seems to fix it, but our website's main bundle size seems to increases for unexpected reasons. For that reason, I'm going to wait for a stable release.

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 9, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 9, 2024 12:47
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2024
Copy link

netlify bot commented May 9, 2024

[V2]

Name Link
🔨 Latest commit 4f7e80c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/663e26ebb5d5ec0008a76e59
😎 Deploy Preview https://deploy-preview-10119--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 47 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 65 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented May 9, 2024

Size Change: 0 B

Total Size: 1.71 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.9 kB
website/.docusaurus/globalData.json 107 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 275 kB
website/.docusaurus/routes.js 179 kB
website/.docusaurus/routesChunkNames.json 119 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 112 kB
website/build/assets/js/main.********.js 853 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber marked this pull request as draft May 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants