Fixed playground draggable block while scrolled #5844
Conversation
Adjusted the ondrop so the element is able to be dropped at the top while scrolled
Legonois
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
I guess this PR is meant to supersede the #5839 ? So 5839 is closable? |
|
Correct, is there a way to append a PR without making a new one? I'm still new with open-source contributions still lol |
You should have just pushed to the original branch, it would have reflected in the existing Pull Request. No worries! We were all once beginners :) I'll close the other PR. |
|
Still not able to reproduce this issue in the current Playground |
| @@ -361,7 +361,8 @@ function useDraggableBlockMenu( | |||
| return true; | |||
| } | |||
| const targetBlockElemTop = targetBlockElem.getBoundingClientRect().top; | |||
| if (pageY / calculateZoomLevel(target) >= targetBlockElemTop) { | |||
| const adjsutedTop = targetBlockElemTop + window.scrollY; | |||
| if (pageY / calculateZoomLevel(target) >= adjsutedTop) { | |||
There was a problem hiding this comment.
nit: typo in adjsutedTop
There was a problem hiding this comment.
@Legonois are you planning on fixing the typo, so we can proceed forward with the merge
|
Just checked the deployments for the bug and it seems fixed! Tell me if there is anything else I need to do before this can be pulled to main |
perhaps rebase and fix the typo |
Last pull request did not include the fix for the actual on drop event, only for the placement of the target line. This adjusts the drop event to account for scrolling