Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover text for tags in ScrollView #4116

Closed
wants to merge 1 commit into from

Conversation

apicgg
Copy link
Contributor

@apicgg apicgg commented May 15, 2024

@cortinico I know it's not much but it adds the hover text on platform tags for ScrollView page.

see #3047

Copy link

netlify bot commented May 15, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit d343dff
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/664517b9aef8040008cc0735
😎 Deploy Preview https://deploy-preview-4116--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Simek
Copy link
Collaborator

Simek commented May 15, 2024

Thanks for working on this improvement! 👍

We probably should make the platform tag a component, which accepts platform prop and based on that render the correct content, so we don't need to copy over the alt text to every platform mark use-case across smany doc pages. But this also meant that we need to replace all manual HTML header additions with new component.

Please let me know if you are interested in trying to introduce this new component and address the issue in more comprehensive way. Happy to help you with this, but if you are not interested it's also fine, I can make a follow up PR in the future.

@apicgg
Copy link
Contributor Author

apicgg commented May 16, 2024

@Simek Making it a platform tag component sounds good. I am more than happy and interested to help introducing this new component. Thanks.

@apicgg
Copy link
Contributor Author

apicgg commented Jun 2, 2024

This is being fixed by #4132

@apicgg apicgg closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants