Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide toggleable hidden column in column toggle dropdown #12854

Conversation

dev-idkwhoami
Copy link
Contributor

Description

This is related to issue #12780.

When deciding whether the dropdown action should be visible and when rendering the dropdown items the code did not check if the column is hidden.

Visual changes

Before:
image

After:
image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@untillnesss
Copy link

This is what happened to me, and I need this, immediately merge and release this change!

@NathanaelGT
Copy link
Contributor

This PR solves my issue 👍

@danharrin danharrin linked an issue May 20, 2024 that may be closed by this pull request
@danharrin danharrin added the bug Something isn't working label May 20, 2024
@danharrin danharrin added this to the v3 milestone May 20, 2024
@danharrin
Copy link
Member

Can you please refactor this so isHidden() is checked inside the isToggleable() method, as an early return maybe? Then we don't need to worry about doing this in each place :)

immediately merge and release this change!

@untillnesss patience... you're message comes across very demanding

@danharrin danharrin self-assigned this May 20, 2024
@danharrin danharrin merged commit 25e0563 into filamentphp:3.x May 20, 2024
10 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Toggle Checkbox Remains Visible When the Column is Hidden
4 participants