Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Floating toolbar labels. #2561

Closed
wants to merge 5 commits into from
Closed

Conversation

brianblakely
Copy link
Contributor

Issue

When hovering over the viewer toolbar, button width changes and shifts the position of buttons onscreen. This can be problematic if you hover over a toolbar button en-route to, for example, the theme picker, as illustrated below. In the diagram, X1 is the original distance from the plugin selector to the theme picker, and X2 is the new distance after hovering over another toolbar button en route.

psp_orig

psp_orig2

Proposed Solution

Instead of rendering button labels inline, render them floating below the toolbar buttons. This floating system works with the theme picker dropdown as well.

psp_float

simplescreenrecorder-2024-03-10_21.19.25.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image was centered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A light variant of this graphic was required for Pro Light, because the original was the same color as the dropdown background.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly more semantic/accessible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image now configurable by theme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merely whitespace consistency.

width: calc(100% + 28px);
height: 36px;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pseudo-element positioned in gap allows cursor to traverse from toolbar button to dropdown without losing hover.

@finos finos deleted a comment from finos-cla-bot bot May 30, 2024
@finos finos deleted a comment from finos-admin May 30, 2024
@finos finos deleted a comment from finos-cla-bot bot May 30, 2024
@texodus
Copy link
Member

texodus commented May 30, 2024

@brianblakely Thanks for the PR!

I've cherry-picked these commits into #2618 (1acea92), with a few modifications, a slightly different presentation, and I've reverted the Theme button changes as this dropdown specifically is particularly hairy to use in float position as you must hover the mouse through a narrow gauntlet to arrive on a clickable surface.

Screen.Recording.2024-05-30.at.3.56.26.PM.mov

#2618 has already been merged and will be in the 3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants