Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rive package to 0.13.5 #3159

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NashIlli
Copy link
Contributor

Description
Allow new features from Rive, like integrated audio and improve performance in 32 bits devices.

Checklist
I have followed the [Contributor Guide] when preparing my PR.
[-] I have updated/added tests for ALL new/updated/fixed functionality.
[-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
I have updated/added relevant examples in examples or docs.
Breaking Change?
No, this PR is not a breaking change.

@spydon spydon enabled auto-merge (squash) May 24, 2024 06:49
Copy link
Collaborator

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NashIlli, rive component tests are failing at set-up with the newer version

auto-merge was automatically disabled May 24, 2024 11:41

Head branch was pushed to by a user without write access

@NashIlli NashIlli changed the title chore: Update rive package to 0.13.4 chore: Update rive package to 0.13.5 May 24, 2024
@NashIlli
Copy link
Contributor Author

@ufrshubham

I've been investigating the issue, and it appears to be a known problem with the Rive library specifically affecting tests. The details are explained in this GitHub issue comment.

Unfortunately, this is a limitation that they are not able to address quickly, which means I am unable to resolve the test error during setup at this time. But they said that it's only a "Testing time problem"

Please review the linked discussion for more context.

champ96k

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants