-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test remaining transitions api examples #148302
Test remaining transitions api examples #148302
Conversation
examples/api/test/widgets/transitions/align_transition.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/align_transition.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/align_transition.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/animated_builder.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/scale_transition.0_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
examples/api/test/widgets/transitions/size_transition.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/listenable_builder.2_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/widgets/transitions/sliver_fade_transition.0_test.dart
Outdated
Show resolved
Hide resolved
Thanks for the reviews so far. FYI: I will be on vacation over the next ~2 weeks and will fix any issues that come up during that time after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 13 new tests 👍
flutter/flutter@8d955cd...8dd0831 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) (flutter/flutter#149039) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) (flutter/flutter#149035) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) (flutter/flutter#149030) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) (flutter/flutter#149028) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) (flutter/flutter#149025) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) (flutter/flutter#149021) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 768c90ee5dc7 to d78f66753332 (3 revisions) (flutter/flutter#149011) 2024-05-23 nate.w5687@gmail.com Reland "Update `FocusManager` platform check to include iOS" (flutter/flutter#148984) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad12c5d02a8c to 768c90ee5dc7 (2 revisions) (flutter/flutter#149003) 2024-05-23 tessertaha@gmail.com Fix `SnackBar` action text button overlay color (flutter/flutter#148961) 2024-05-23 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148930) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a48302f6f4e to ad12c5d02a8c (3 revisions) (flutter/flutter#148993) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 964f087f288c to 2a48302f6f4e (1 revision) (flutter/flutter#148950) 2024-05-23 katelovett@google.com [wiki migration] Remaining pages under docs/contributing/ (flutter/flutter#148790) 2024-05-23 katelovett@google.com [wiki migration] Web team pages (flutter/flutter#148777) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test remaining transitions api examples (flutter/flutter#148302) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test snack bar examples (flutter/flutter#147774) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Add tests for material banner example (flutter/flutter#147733) 2024-05-23 engine-flutter-autoroll@skia.org Roll Packages from 6525441 to 1008d9e (6 revisions) (flutter/flutter#148980) 2024-05-23 goderbauer@google.com Revert "const vs. non-const widget build benchmark" (flutter/flutter#148970) 2024-05-23 ian@hixie.ch Remove hidden dependencies on HttpClient (flutter/flutter#148773) 2024-05-23 rmolivares@renzo-olivares.dev Revert "Update `FocusManager` platform check to include iOS" (flutter/flutter#148978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds tests for
relative_positioned_transition
,positioned_transition
,sliver_fade_transition
,align_transition
,animated_builder
,rotation_transition
,animated_widget
,slide_transition
,listenable_builder
,scale_transition
,default_text_style_transition
,decorated_box_transition
,size_transition
api examples. Makes double type in thealign_transition
example explicit.A test for
fade_transition
is already in currently open #148178.Part of #130459.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.