Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): fixed strict regex #54778

Merged
merged 1 commit into from
May 14, 2024

Conversation

AndrewYturaldi
Copy link
Contributor

fix(curriculum): fixed strict regex

fix(curriculum): fixed strict regex

Checklist:

Closes #54744

This change allows for the 1 to be included inside the argument of Math.floor(), meaning the following code is now passes:

const randomDice = Math.floor((Math.random() * 6) + 1)

I added the optional parenthesis to line 37 as well because otherwise it was seen as required, and would show the "You should use Math.floor()..." hint.

fix(curriculum): fixed strict regex

fix(curriculum): fixed strict regex
@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 14, 2024
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 14, 2024
@naomi-lgbt naomi-lgbt merged commit 1a97345 into freeCodeCamp:main May 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dice Game - Step 16: regex too strict
4 participants