Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(playwright): minor update to signin.spec.ts #54781

Merged
merged 2 commits into from
May 14, 2024
Merged

test(playwright): minor update to signin.spec.ts #54781

merged 2 commits into from
May 14, 2024

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented May 14, 2024 •
edited

Checklist:

This PR follows up to #54752 and changes the page navigation in the signin.spec.ts test.

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 14, 2024
huyenltnguyen
huyenltnguyen commented May 14, 2024
View reviewed changes
e2e/signin.spec.ts Show resolved Hide resolved
e2e/signin.spec.ts Show resolved Hide resolved
@huyenltnguyen huyenltnguyen marked this pull request as ready for review May 14, 2024 08:28
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner May 14, 2024 08:28
ojeytonwilliams
ojeytonwilliams requested changes May 14, 2024
View reviewed changes
e2e/signin.spec.ts Outdated Show resolved Hide resolved
@huyenltnguyen huyenltnguyen changed the title test(playwright): add a new test case to signin.spec.ts test(playwright): minor update to signin.spec.ts May 14, 2024
ojeytonwilliams
ojeytonwilliams approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @huyenltnguyen. LGTM 👍

@naomi-lgbt naomi-lgbt merged commit f826596 into freeCodeCamp:main May 14, 2024
22 checks passed
@huyenltnguyen huyenltnguyen deleted the test/dev-user-signin branch May 14, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huyenltnguyen @ojeytonwilliams @naomi-lgbt