move ndk code to a new library

[eltonkola]

move ndk code to a new module, so it can be published later on as an android library and easily integrated ion third party apps

[mofosyne]

was this tab here intentional?

[eltonkola]

no, androidstudio must have done it

[mofosyne]

Ah fair enough. If it looks better with the space in your opinion then that's fine.

CI is throwing up some error so you got some opportunities to fix that nitpick if you feel like it.

[ggerganov]

The CI is likely failing because the Android project pull llama.cpp from the master branch:

llama.cpp/examples/llama.android/app/src/main/cpp/CMakeLists.txt

Lines 9 to 21 in e0f5561

	# Declares the project name. The project name can be accessed via ${ PROJECT_NAME},
	# Since this is the top level CMakeLists.txt, the project name is also accessible
	# with ${CMAKE_PROJECT_NAME} (both CMake variables are in-sync within the top level
	# build script scope).
	project("llama-android")
	include(FetchContent)
	FetchContent_Declare(
	llama
	GIT_REPOSITORY https://github.com/ggerganov/llama.cpp
	GIT_TAG master
	)

So it is mixing changes from this PR and what is currently on master. Not familiar enough with Android build system to figure out how to fix this

Let's merge and see if it works

[mofosyne]

double checking to see if this changes touches any non android stuff. Looks safe.

So merging now and fingers crossed it's as gg said that ci will pass in master for the android build

[mofosyne]

@eltonkola CI failed for your android code in main branch, so can you see if you can make a correction for it as a separate PR?

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
   > Could not resolve project :llama.
     Required by:
         project :app
      > No matching configuration of project :llama was found. The consumer was configured to find a library for use during compile-time, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug', attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '8.2.0', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
          - None of the consumable configurations have attributes.\

[mofosyne]

Will wait a day or two if we can figure this out, else will revert this PR to avoid polluting the CI output of the main branch.