-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix self extend on the server. #7239
Draft
Maximilian-Winter
wants to merge
2
commits into
ggerganov:master
Choose a base branch
from
Maximilian-Winter:fixed_self_extension
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix self extend on the server. #7239
Maximilian-Winter
wants to merge
2
commits into
ggerganov:master
from
Maximilian-Winter:fixed_self_extension
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
examples
review complexity : low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
server
help wanted
Extra attention is needed
labels
May 12, 2024
I did additional tests and realized that the code that was previously removed didn't was called anyway. But in my tests it works as it should and it will find the passkey. For example hermes pro llama 8b with 8k context can retrieve the pass key with self extend from 50k tokens text, but will produce garbage without it. |
It's probably better to go back and see which change makes the server test fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
examples
help wanted
Extra attention is needed
review complexity : low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The self extend is broken on the server according to this.
#7005
This PR tries to fix the self extend mechanism in the server. I tested it with passkey test and it could predict the passkey correctly. I have replicated the passkey test of llama.cpp, because I wasn't sure about how to interpret the results of the behave run. I basically copied the showed prompt from the behave passkey test and added token "[INST]" at the beginning and "[/INST]" at the end. Then I runned it on the completion endpoint.
Would be happy if someone could test it and give it a try
Edit:
Did another test with mistral instruct v0.2 with 50.000 context text and the passkey once in the middle. It worked really well. Did another test without self extend enabled and it sayed that the passkey isn't in the text.