Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): support custom node bin path in shebang #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephschmitt
Copy link
Contributor

The custom path is set in the ghooks config right now because I couldn't think of a better place for it. Let me know if you have a better idea.

@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #225   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          99    107    +8     
  Branches        4      4           
=====================================
+ Hits           99    107    +8
Impacted Files Coverage Δ
lib/hook.template.raw 100% <ø> (ø) ⬆️
lib/hook.template.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6128d0b...70b95e2. Read the comment docs.

@josephschmitt josephschmitt force-pushed the node-bin branch 3 times, most recently from 835b228 to 5cc208c Compare April 26, 2018 17:23
The custom path is set in the ghooks config right now because I couldn't think of a better place for it. Let me know if you have a better idea.
@gtramontina
Copy link
Collaborator

Once again, thank you for the contribution!

That's a nice customization! Is this an issue you're currently experiencing?

Regarding where to put ghooks "settings", we've discussed it in the past #81. Haven't reached a consensus, though… But I think that #81 (comment) can be a good first step…

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants