Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always run hooks as CommonJS #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brady-ds
Copy link

When installing hooks, add a package.json with type: 'commonjs' to …/.git/hooks/ to force the hooks to run as CommonJS, not modules, regardless of the type set in the outer package.json.

Fixes #394.

Add a `package.json` to `…/.git/hooks/` to force hooks to run as CommonJS, not
modules.

Fixes ghooks-org#394.
@gtramontina
Copy link
Collaborator

Hey there @brady-ds. Thanks for putting the effort! 🙏

It's been a while since I've done any maintenance in this repository. I'll do some clean up/bump up versions before bringing in/reviewing your changes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Breaks when used in ES Modules context due to requirement for file name extension
2 participants