Improve OpenGL documentation in Internal rendering architecture #9384
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
topic:rendering
area:contributing
mhilbrunner
approved these changes
May 16, 2024
AThousandShips
approved these changes
May 16, 2024
clayjohn
reviewed
May 16, 2024
contributing/development/core_and_modules/internal_rendering_architecture.rst
Outdated
Show resolved
Hide resolved
Calinou
force-pushed
the
internal-rendering-architecture-opengl
branch
from
d090057
to
933c506
Compare
Calinou
force-pushed
the
internal-rendering-architecture-opengl
branch
2 times, most recently
from
362f1ca
to
0a1a4bb
Compare
- Mention that OpenGL ES can be run directly on desktop platforms with a command line argument. - Remove notice about some OpenGL features being unimplemented, as the Compatibility rendering is pretty much feature-complete as of 4.3. - Update URL for the Vulkan rendering driver to follow RenderingDeviceDriver changes. - Fix incorrect notice about the D3D12 rendering driver transpiling GLSL to HLSL (it transpiles SPIR-V to DXIL instead).
Calinou
force-pushed
the
internal-rendering-architecture-opengl
branch
from
0a1a4bb
to
8e6067d
Compare
|
@Calinou I see you pushed to this to add that SPIR-V info. Do you still want to make changes or is this good to merge? |
This should be good to merge now 🙂 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not cherry-pickable for 4.2, as the OpenGL renderer is only feature-complete starting from 4.3.