Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started with Gemini: Fix "generation configuration" step #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Weiyuan-Lane
Copy link

Description of the change

While running this lab for a "Build with AI" event, noticed some issues with running the lab.
Proposing a change to allow for future participants to not face the same issue.

Motivation

Adding screenshots to show the fix better:

Current iteration:
Screenshot 2024-03-17 at 1 55 51 PM

After making the changes:
Screenshot 2024-03-17 at 1 55 12 PM

Type of change

Choose one: Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Weiyuan-Lane Weiyuan-Lane requested a review from a team as a code owner March 17, 2024 06:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Mar 17, 2024
@Weiyuan-Lane Weiyuan-Lane changed the title Fix "generation configuration" step Getting Started with Gemini: Fix "generation configuration" step Mar 17, 2024
@markmcd
Copy link
Member

markmcd commented Mar 18, 2024

This is a helpful suggestion - though I'd rather we didn't need to do this at all (and ideally we don't need to include bug workarounds in our quickstarts).

I'll talk to the team and see if we can fix this in a better way. If not we can apply your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:documentation Update docs status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants