Test build.rs cfgs using rustversion crate
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test code which is conditionally-compiled on different versions of the Rust toolchain, we previously relied on the same infrastructure as the runtime code - `--cfg` arguments emitted by our `build.rs` file. This, however, is using a feature to test itself. In this change, we switch to using the `rustversion` crate so that bugs in `build.rs` can't hide themselves by silently disabling the relevant tests.
joshlf
force-pushed
the
cfg-test-rustversion
branch
from
8afda0b
to
47a275d
Compare
auto-merge was automatically disabled
March 3, 2024 17:27
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test code which is conditionally-compiled on different versions of the Rust toolchain, we previously relied on the same infrastructure as the runtime code -
--cfgarguments emitted by ourbuild.rsfile. This, however, is using a feature to test itself. In this change, we switch to using therustversioncrate so that bugs inbuild.rscan't hide themselves by silently disabling the relevant tests.