Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F add resource aws redshift idc application #37345

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

noel-phelt
Copy link
Contributor

Description

Add redshift_idc_application resource.

Relations

Relates #35829

References

Output from Acceptance Testing

# make testacc TESTS=TestAccRedshiftIdcApplication PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftIdcApplication'  -timeout 360m
=== RUN   TestAccRedshiftIdcApplication_basic
=== PAUSE TestAccRedshiftIdcApplication_basic
=== RUN   TestAccRedshiftIdcApplication_disappears
=== PAUSE TestAccRedshiftIdcApplication_disappears
=== RUN   TestAccRedshiftIdcApplication_authorizedTokenIssuerList
=== PAUSE TestAccRedshiftIdcApplication_authorizedTokenIssuerList
=== RUN   TestAccRedshiftIdcApplication_serviceIntegrations
=== PAUSE TestAccRedshiftIdcApplication_serviceIntegrations
=== CONT  TestAccRedshiftIdcApplication_basic
=== CONT  TestAccRedshiftIdcApplication_authorizedTokenIssuerList
=== CONT  TestAccRedshiftIdcApplication_disappears
=== CONT  TestAccRedshiftIdcApplication_serviceIntegrations
--- PASS: TestAccRedshiftIdcApplication_disappears (32.01s)
--- PASS: TestAccRedshiftIdcApplication_basic (33.63s)
--- PASS: TestAccRedshiftIdcApplication_serviceIntegrations (33.80s)
--- PASS: TestAccRedshiftIdcApplication_authorizedTokenIssuerList (33.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	34.108s

Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. generators Relates to code generators. labels May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
@noel-phelt noel-phelt marked this pull request as ready for review May 10, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants