Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes aws_lb_listener datasource's default_action's target_group_arn #37348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmarlok88
Copy link
Contributor

Fixes #36459 where the default_action's target_group_arn is not filled in an aws_lb_listener datasource

Description

The default_action.target_group_arn attribute in an aws_lb_listener data source is empty.

Relations

Closes #36459

References

The bug was introduced in this PR: #35671

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_basic' PKG=elbv2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2ListenerDataSource_basic -timeout 360m
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== CONT  TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2ListenerDataSource_basic (228.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	228.617s

...

…not filled in an aws_lb_listener datasource
Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
@tmarlok88 tmarlok88 changed the title Fixes #36459 where the default_action's target_group_arn is not fille… Fixes aws_lb_listener datasource's default_action's target_group_arn May 8, 2024
@tmarlok88
Copy link
Contributor Author

@gdavison This fix messes with your recent PR (mentioned in the description), please give some sanity check if you have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_lb_listener Datastore's default_action is not filled if the type is forward
1 participant