-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for default_tags and tags on EC2 block devices #37441
base: main
Are you sure you want to change the base?
Conversation
`default_tags` support for EC2 root block devices was introduced in hasicorp/terraform-provider-aws#33769, which is great ... except it makes the mix of `default_tags` and `tags` on a `root_block_device` perpetually showing drift even when there is none. The solution is to not remove the default tags config from the volume tags in ec2_instance. This diff fixes hashicorp#36448 for us in our environment (which references hashicorp#33769 as the change that introduced this bug). This diff possibly fixes hashicorp#36706 too, but we weren't hitting this issue.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @0xkag 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Any interest in merging this? |
Description
default_tags
support for EC2 root block devices was introduced in #33769, which is great ... except it makes the mix ofdefault_tags
andtags
on aroot_block_device
perpetually showing drift even when there is none.The solution is to not remove the default tags config from the volume tags in ec2_instance.
This diff fixes #36448 for us in our environment (which references #33769 as the change that introduced this bug).
This diff possibly fixes #36706 too, but we weren't hitting this issue.
Relations
Relates #33769
Relates #36706
Closes #36448
Output from Acceptance Testing