Feature/app fabric app authorization #37468

markoskandylis · 2024-05-13T12:44:13Z

Description

This PR adds a resource for aws_appfabric_app_authorization

https://docs.aws.amazon.com/appfabric/latest/api/API_CreateAppAuthorization.html

Relations

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric  ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 1  -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/AppAuthorization
=== RUN   TestAccAppFabric_serial/AppAuthorization/tags
=== PAUSE TestAccAppFabric_serial/AppAuthorization/tags
=== RUN   TestAccAppFabric_serial/AppAuthorization/basic
=== PAUSE TestAccAppFabric_serial/AppAuthorization/basic
=== RUN   TestAccAppFabric_serial/AppAuthorization/disappears
=== PAUSE TestAccAppFabric_serial/AppAuthorization/disappears
=== RUN   TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== PAUSE TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN   TestAccAppFabric_serial/AppAuthorization/oath2Update
=== PAUSE TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT  TestAccAppFabric_serial/AppAuthorization/tags
=== CONT  TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== CONT  TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT  TestAccAppFabric_serial/AppAuthorization/disappears
=== CONT  TestAccAppFabric_serial/AppAuthorization/basic
--- PASS: TestAccAppFabric_serial (98.97s)
    --- PASS: TestAccAppFabric_serial/AppAuthorization (0.00s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/tags (32.37s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (22.05s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (22.09s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (10.40s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/basic (12.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	104.407s

...

github-actions · 2024-05-13T12:44:27Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

markoskandylis · 2024-05-13T14:46:36Z

After fixing the tests:
make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 1 -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT TestAccAppFabric_serial
=== RUN TestAccAppFabric_serial/AppAuthorization
=== RUN TestAccAppFabric_serial/AppAuthorization/disappears
=== PAUSE TestAccAppFabric_serial/AppAuthorization/disappears
=== RUN TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== PAUSE TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN TestAccAppFabric_serial/AppAuthorization/oath2Update
=== PAUSE TestAccAppFabric_serial/AppAuthorization/oath2Update
=== RUN TestAccAppFabric_serial/AppAuthorization/tags
=== PAUSE TestAccAppFabric_serial/AppAuthorization/tags
=== RUN TestAccAppFabric_serial/AppAuthorization/basic
=== PAUSE TestAccAppFabric_serial/AppAuthorization/basic
=== CONT TestAccAppFabric_serial/AppAuthorization/disappears
=== CONT TestAccAppFabric_serial/AppAuthorization/tags
=== CONT TestAccAppFabric_serial/AppAuthorization/basic
=== CONT TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
--- PASS: TestAccAppFabric_serial (97.39s)
--- PASS: TestAccAppFabric_serial/AppAuthorization (0.00s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (10.64s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/tags (31.34s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/basic (11.82s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (21.69s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (21.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appfabric 102.808s

meetreks

Excellent code, job well done. Just some minor edits to follow.

meetreks · 2024-05-18T15:27:29Z

internal/service/appfabric/app_authorization.go

+// SPDX-License-Identifier: MPL-2.0
+
+package appfabric
+


meetreks · 2024-05-18T15:32:08Z

internal/service/appfabric/app_authorization.go

+func (r *appAuthorizationResource) Schema(ctx context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) {
+	resp.Schema = schema.Schema{
+		Attributes: map[string]schema.Attribute{
+			"app": schema.StringAttribute{


Please consider adding a ENUM as it accepts only valid values.

The documentation doesnt have all the valid values thats why i didnt add Enums

meetreks · 2024-05-18T15:34:57Z

internal/service/appfabric/app_authorization_test.go

+
+resource "aws_appfabric_app_authorization" "test" {
+  app_bundle_identifier = aws_appfabric_app_bundle.arn
+  app                   = "TERRAFORMCLOUD"


Is this a valid value? As per this doco - looks like itts noto a valid value -- https://docs.aws.amazon.com/appfabric/latest/api/API_CreateAppAuthorization.html

Yes its Valid the docs doenst have all the possible names that was tested

meetreks · 2024-05-18T15:35:16Z

internal/service/appfabric/app_authorization_test.go

+
+
+resource "aws_appfabric_app_authorization" "test" {
+  app_bundle_identifier = aws_appfabric_app_bundle.arn


Where is the resource for this?

This is still on creation the tests will be updated with the team that is working on that resource will make a pull request

meetreks · 2024-05-18T15:36:47Z

internal/service/appfabric/app_authorization_test.go

+	}
+}
+
+func testAccAppAuthorizationConfig_basic() string {


The return requires formatting..

meetreks · 2024-05-18T15:39:10Z

internal/service/appfabric/appfabric_test.go

@@ -0,0 +1,27 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+


why is this file included?

This is a way to test the cases see example on Security lake, and bedrock knowledge base. @ewbankkit will that be the way forward for tests or we should default to the old tests

meetreks · 2024-05-18T15:40:52Z

website/docs/r/appfabric_app_authorization.html.markdown

+```terraform
+resource "aws_appfabric_app_authorization" "example" {
+  app                   = "TERRAFORMCLOUD"
+  app_bundle_identifier = aws_appfabric_app_bundle.arn


include a resource for app_bundle.arn and the formatting is incorrect. You might want to consider aws_appfabric_app_bundle.test.arn

Yes the resource is not ready yet waiting for the pull request

markoskandylis added 3 commits May 13, 2024 13:23

First tests passed

6804340

First tests passed succesfully

1b204de

All tests passeed succesfully and added docs

e44a0eb

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels May 13, 2024

markoskandylis added 2 commits May 13, 2024 15:36

Fixing linters

bb3ffc5

Fixing linters

87307c0

markoskandylis marked this pull request as ready for review May 13, 2024 14:46

Fixing linters

0432d66

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024

meetreks reviewed May 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/app fabric app authorization #37468

Feature/app fabric app authorization #37468

markoskandylis commented May 13, 2024

github-actions bot commented May 13, 2024

markoskandylis commented May 13, 2024

meetreks left a comment

meetreks May 18, 2024

meetreks May 18, 2024

markoskandylis May 18, 2024 •

edited

meetreks May 18, 2024

markoskandylis May 18, 2024

meetreks May 18, 2024

markoskandylis May 18, 2024

meetreks May 18, 2024

meetreks May 18, 2024

markoskandylis May 18, 2024

meetreks May 18, 2024

markoskandylis May 18, 2024



		resource "aws_appfabric_app_authorization" "test" {
		app_bundle_identifier = aws_appfabric_app_bundle.arn

		@@ -0,0 +1,27 @@
		// Copyright (c) HashiCorp, Inc.
		// SPDX-License-Identifier: MPL-2.0

Feature/app fabric app authorization #37468

Are you sure you want to change the base?

Feature/app fabric app authorization #37468

Conversation

markoskandylis commented May 13, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented May 13, 2024

Community Note

markoskandylis commented May 13, 2024

meetreks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markoskandylis May 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markoskandylis May 18, 2024 •

edited