Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows generating tag tests for resource types that use self-signed certificates #37483

Merged
merged 3 commits into from
May 15, 2024

Conversation

gdavison
Copy link
Contributor

Description

Allows generating tag tests for resource types that use self-signed certificates

Fixes error with aws_iam_server_certificate not reading tags after update or on read

Output from Acceptance Testing

% make testacc PKG=iam TESTS=TestAccIAMServerCertificate_tags

--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag (37.37s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag (37.57s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag (37.83s)
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnCreate (39.38s)
--- PASS: TestAccIAMServerCertificate_tags_null (45.76s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly (51.30s)
--- PASS: TestAccIAMServerCertificate_tags_AddOnUpdate (51.48s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace (52.17s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly (52.86s)
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add (54.98s)
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace (54.94s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnCreate (56.13s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add (67.07s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping (70.13s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_overlapping (72.71s)
--- PASS: TestAccIAMServerCertificate_tags_BASIC (79.38s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_providerOnly (79.46s)

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. generators Relates to code generators. labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 13, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison force-pushed the td-generate-tagtests-tlscert branch 3 times, most recently from ea28262 to 0592155 Compare May 15, 2024 20:19
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison force-pushed the td-generate-tagtests-tlscert branch from 0592155 to 864fa56 Compare May 15, 2024 20:46
@gdavison gdavison force-pushed the td-generate-tagtests-tlscert branch from 864fa56 to b436c1f Compare May 15, 2024 21:35
@gdavison gdavison merged commit 8d65842 into main May 15, 2024
37 checks passed
@gdavison gdavison deleted the td-generate-tagtests-tlscert branch May 15, 2024 21:56
@github-actions github-actions bot added this to the v5.50.0 milestone May 15, 2024
github-actions bot pushed a commit that referenced this pull request May 15, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants