Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single custom label in GHA jobs #37485

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

dlaguerta
Copy link
Contributor

@dlaguerta dlaguerta commented May 13, 2024

Description

馃憢 Greetings!

To align with Github鈥檚 removal of custom labels on larger runners, this PR is updating the labels defined in your Github Action jobs. Moving forward, only one label (the name of GH runner type) will be needed to ensure an appropriate runner is used for your GHA job.

Please review for accuracy and merge before May 27, 2024. Thank you!

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 馃憤 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label May 13, 2024
Copy link

Hey @dlaguerta 馃憢 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dlaguerta 馃憢

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven鈥檛 already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 馃槂

@dlaguerta dlaguerta force-pushed the PSS-139-gh-runner-labels-cleanup branch from ece7b5b to 10d97fb Compare May 13, 2024 23:32
@dlaguerta dlaguerta changed the title migrate GHA workflows to using single runner labels Use single custom label in GHA jobs May 16, 2024
@dlaguerta dlaguerta marked this pull request as ready for review May 16, 2024 18:40
@justinretzolk justinretzolk added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
@YakDriver YakDriver merged commit df6fdbe into main May 16, 2024
86 checks passed
@YakDriver YakDriver deleted the PSS-139-gh-runner-labels-cleanup branch May 16, 2024 21:04
@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants