Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use attribute literals for serialized test names #37504

Merged
merged 4 commits into from
May 15, 2024
Merged

Don't use attribute literals for serialized test names #37504

merged 4 commits into from
May 15, 2024

Conversation

gdavison
Copy link
Contributor

Description

Updates the semgrep rules for attribute literals to exclude serialized test names.

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/guardduty Issues and PRs that pertain to the guardduty service. service/configservice Issues and PRs that pertain to the configservice service. service/apigateway Issues and PRs that pertain to the apigateway service. service/directconnect Issues and PRs that pertain to the directconnect service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/lightsail Issues and PRs that pertain to the lightsail service. service/organizations Issues and PRs that pertain to the organizations service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/appsync Issues and PRs that pertain to the appsync service. service/workspaces Issues and PRs that pertain to the workspaces service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/route53domains Issues and PRs that pertain to the route53domains service. service/fms Issues and PRs that pertain to the fms service. service/connect Issues and PRs that pertain to the connect service. service/chime Issues and PRs that pertain to the chime service. service/s3control Issues and PRs that pertain to the s3control service. service/amplify Issues and PRs that pertain to the amplify service. service/transfer Issues and PRs that pertain to the transfer service. service/securityhub Issues and PRs that pertain to the securityhub service. service/appmesh Issues and PRs that pertain to the appmesh service. service/fsx Issues and PRs that pertain to the fsx service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/servicequotas Issues and PRs that pertain to the servicequotas service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/detective Issues and PRs that pertain to the detective service. labels May 14, 2024
@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. generators Relates to code generators. service/grafana Issues and PRs that pertain to the grafana service. service/ipam Issues and PRs that pertain to the ipam service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/vpc Issues and PRs that pertain to the vpc service. service/controltower Issues and PRs that pertain to the controltower service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/securitylake Issues and PRs that pertain to the securitylake service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels May 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 14, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

ewbankkit
ewbankkit approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 716e8af into main May 15, 2024
37 checks passed
@gdavison gdavison deleted the td-literals-cleanup branch May 15, 2024 20:38
@github-actions github-actions bot added this to the v5.50.0 milestone May 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. linter Pertains to changes to or issues with the various linters. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/appmesh Issues and PRs that pertain to the appmesh service. service/appsync Issues and PRs that pertain to the appsync service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/controltower Issues and PRs that pertain to the controltower service. service/detective Issues and PRs that pertain to the detective service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/fms Issues and PRs that pertain to the fms service. service/fsx Issues and PRs that pertain to the fsx service. service/grafana Issues and PRs that pertain to the grafana service. service/guardduty Issues and PRs that pertain to the guardduty service. service/ipam Issues and PRs that pertain to the ipam service. service/ivs Issues and PRs that pertain to the ivs service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/lightsail Issues and PRs that pertain to the lightsail service. service/macie2 Issues and PRs that pertain to the macie2 service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/organizations Issues and PRs that pertain to the organizations service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/route53domains Issues and PRs that pertain to the route53domains service. service/s3control Issues and PRs that pertain to the s3control service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/securityhub Issues and PRs that pertain to the securityhub service. service/securitylake Issues and PRs that pertain to the securitylake service. service/servicequotas Issues and PRs that pertain to the servicequotas service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/transfer Issues and PRs that pertain to the transfer service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit