Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate route53 resources to AWS SDK for Go v2 #37510

Merged
merged 40 commits into from
May 20, 2024
Merged

Migrate route53 resources to AWS SDK for Go v2 #37510

merged 40 commits into from
May 20, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 14, 2024 •
edited

Description

Ibid.

Relations

Closes #36203.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRoute53' PKG=route53 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 4  -run=TestAccRoute53 -timeout 720m
=== RUN   TestAccRoute53CIDRCollection_basic
=== PAUSE TestAccRoute53CIDRCollection_basic
=== RUN   TestAccRoute53CIDRCollection_disappears
=== PAUSE TestAccRoute53CIDRCollection_disappears
=== RUN   TestAccRoute53CIDRLocation_basic
=== PAUSE TestAccRoute53CIDRLocation_basic
=== RUN   TestAccRoute53CIDRLocation_update
=== PAUSE TestAccRoute53CIDRLocation_update
=== RUN   TestAccRoute53DelegationSetDataSource_basic
--- PASS: TestAccRoute53DelegationSetDataSource_basic (100.59s)
=== RUN   TestAccRoute53DelegationSet_basic
=== PAUSE TestAccRoute53DelegationSet_basic
=== RUN   TestAccRoute53DelegationSet_withZones
=== PAUSE TestAccRoute53DelegationSet_withZones
=== RUN   TestAccRoute53DelegationSet_disappears
=== PAUSE TestAccRoute53DelegationSet_disappears
=== RUN   TestAccRoute53HealthCheck_basic
=== PAUSE TestAccRoute53HealthCheck_basic
=== RUN   TestAccRoute53HealthCheck_tags
=== PAUSE TestAccRoute53HealthCheck_tags
=== RUN   TestAccRoute53HealthCheck_withSearchString
=== PAUSE TestAccRoute53HealthCheck_withSearchString
=== RUN   TestAccRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccRoute53HealthCheck_withChildHealthChecks
=== RUN   TestAccRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccRoute53HealthCheck_withHealthCheckRegions
=== RUN   TestAccRoute53HealthCheck_ip
=== PAUSE TestAccRoute53HealthCheck_ip
=== RUN   TestAccRoute53HealthCheck_ipv6
=== PAUSE TestAccRoute53HealthCheck_ipv6
=== RUN   TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== PAUSE TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== RUN   TestAccRoute53HealthCheck_withSNI
=== PAUSE TestAccRoute53HealthCheck_withSNI
=== RUN   TestAccRoute53HealthCheck_disabled
=== PAUSE TestAccRoute53HealthCheck_disabled
=== RUN   TestAccRoute53HealthCheck_withRoutingControlARN
=== PAUSE TestAccRoute53HealthCheck_withRoutingControlARN
=== RUN   TestAccRoute53HealthCheck_disappears
=== PAUSE TestAccRoute53HealthCheck_disappears
=== RUN   TestAccRoute53HostedZoneDNSSEC_basic
=== PAUSE TestAccRoute53HostedZoneDNSSEC_basic
=== RUN   TestAccRoute53HostedZoneDNSSEC_disappears
=== PAUSE TestAccRoute53HostedZoneDNSSEC_disappears
=== RUN   TestAccRoute53HostedZoneDNSSEC_signingStatus
=== PAUSE TestAccRoute53HostedZoneDNSSEC_signingStatus
=== RUN   TestAccRoute53KeySigningKey_basic
=== PAUSE TestAccRoute53KeySigningKey_basic
=== RUN   TestAccRoute53KeySigningKey_disappears
=== PAUSE TestAccRoute53KeySigningKey_disappears
=== RUN   TestAccRoute53KeySigningKey_status
=== PAUSE TestAccRoute53KeySigningKey_status
=== RUN   TestAccRoute53QueryLog_basic
=== PAUSE TestAccRoute53QueryLog_basic
=== RUN   TestAccRoute53QueryLog_disappears
=== PAUSE TestAccRoute53QueryLog_disappears
=== RUN   TestAccRoute53QueryLog_Disappears_hostedZone
=== PAUSE TestAccRoute53QueryLog_Disappears_hostedZone
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_cidr
=== PAUSE TestAccRoute53Record_cidr
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_Geoproximity_basic
=== PAUSE TestAccRoute53Record_Geoproximity_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== RUN   TestAccRoute53TrafficPolicyInstance_basic
=== PAUSE TestAccRoute53TrafficPolicyInstance_basic
=== RUN   TestAccRoute53TrafficPolicyInstance_disappears
=== PAUSE TestAccRoute53TrafficPolicyInstance_disappears
=== RUN   TestAccRoute53TrafficPolicyInstance_update
=== PAUSE TestAccRoute53TrafficPolicyInstance_update
=== RUN   TestAccRoute53TrafficPolicy_basic
=== PAUSE TestAccRoute53TrafficPolicy_basic
=== RUN   TestAccRoute53TrafficPolicy_disappears
=== PAUSE TestAccRoute53TrafficPolicy_disappears
=== RUN   TestAccRoute53TrafficPolicy_update
=== PAUSE TestAccRoute53TrafficPolicy_update
=== RUN   TestAccRoute53VPCAssociationAuthorization_basic
=== PAUSE TestAccRoute53VPCAssociationAuthorization_basic
=== RUN   TestAccRoute53VPCAssociationAuthorization_disappears
=== PAUSE TestAccRoute53VPCAssociationAuthorization_disappears
=== RUN   TestAccRoute53VPCAssociationAuthorization_concurrent
=== PAUSE TestAccRoute53VPCAssociationAuthorization_concurrent
=== RUN   TestAccRoute53VPCAssociationAuthorization_crossRegion
=== PAUSE TestAccRoute53VPCAssociationAuthorization_crossRegion
=== RUN   TestAccRoute53ZoneAssociation_basic
=== PAUSE TestAccRoute53ZoneAssociation_basic
=== RUN   TestAccRoute53ZoneAssociation_disappears
=== PAUSE TestAccRoute53ZoneAssociation_disappears
=== RUN   TestAccRoute53ZoneAssociation_Disappears_vpc
=== PAUSE TestAccRoute53ZoneAssociation_Disappears_vpc
=== RUN   TestAccRoute53ZoneAssociation_Disappears_zone
=== PAUSE TestAccRoute53ZoneAssociation_Disappears_zone
=== RUN   TestAccRoute53ZoneAssociation_crossAccount
=== PAUSE TestAccRoute53ZoneAssociation_crossAccount
=== RUN   TestAccRoute53ZoneAssociation_crossRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossRegion
=== RUN   TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== RUN   TestAccRoute53ZoneDataSource_id
=== PAUSE TestAccRoute53ZoneDataSource_id
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== RUN   TestAccRoute53ZoneDataSource_tags
=== PAUSE TestAccRoute53ZoneDataSource_tags
=== RUN   TestAccRoute53ZoneDataSource_vpc
=== PAUSE TestAccRoute53ZoneDataSource_vpc
=== RUN   TestAccRoute53ZoneDataSource_serviceDiscovery
=== PAUSE TestAccRoute53ZoneDataSource_serviceDiscovery
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_disappears
=== PAUSE TestAccRoute53Zone_disappears
=== RUN   TestAccRoute53Zone_multiple
=== PAUSE TestAccRoute53Zone_multiple
=== RUN   TestAccRoute53Zone_comment
=== PAUSE TestAccRoute53Zone_comment
=== RUN   TestAccRoute53Zone_delegationSetID
=== PAUSE TestAccRoute53Zone_delegationSetID
=== RUN   TestAccRoute53Zone_forceDestroy
=== PAUSE TestAccRoute53Zone_forceDestroy
=== RUN   TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== PAUSE TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== RUN   TestAccRoute53Zone_tags
=== PAUSE TestAccRoute53Zone_tags
=== RUN   TestAccRoute53Zone_VPC_single
=== PAUSE TestAccRoute53Zone_VPC_single
=== RUN   TestAccRoute53Zone_VPC_multiple
=== PAUSE TestAccRoute53Zone_VPC_multiple
=== RUN   TestAccRoute53Zone_VPC_updates
=== PAUSE TestAccRoute53Zone_VPC_updates
=== RUN   TestAccRoute53Zone_VPC_single_forceDestroy
=== PAUSE TestAccRoute53Zone_VPC_single_forceDestroy
=== CONT  TestAccRoute53CIDRCollection_basic
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== CONT  TestAccRoute53VPCAssociationAuthorization_disappears
=== CONT  TestAccRoute53Record_basic
=== NAME  TestAccRoute53VPCAssociationAuthorization_disappears
    vpc_association_authorization_test.go:61: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53VPCAssociationAuthorization_disappears (0.00s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53CIDRCollection_basic (10.81s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_basic (182.74s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_nameChange (314.63s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (220.16s)
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (231.77s)
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
--- PASS: TestAccRoute53Record_Latency_basic (198.37s)
=== CONT  TestAccRoute53Record_Geoproximity_basic
--- PASS: TestAccRoute53Record_typeChange (227.35s)
=== CONT  TestAccRoute53Record_Geolocation_basic
=== CONT  TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (223.01s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (253.51s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_Geolocation_basic (200.12s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_Geoproximity_basic (215.46s)
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_cidr (280.26s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Alias_uppercase (170.27s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_Weighted_alias (310.22s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Alias_s3 (180.89s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_Support_spf (166.95s)
=== CONT  TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_Alias_elb (172.18s)
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (358.50s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Weighted_basic (182.10s)
=== CONT  TestAccRoute53VPCAssociationAuthorization_basic
    vpc_association_authorization_test.go:30: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53VPCAssociationAuthorization_basic (0.00s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_generatesSuffix (155.21s)
=== CONT  TestAccRoute53TrafficPolicy_update
--- PASS: TestAccRoute53TrafficPolicy_update (18.10s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_failover (197.26s)
=== CONT  TestAccRoute53TrafficPolicy_disappears
--- PASS: TestAccRoute53TrafficPolicy_disappears (9.07s)
=== CONT  TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_wildcard (233.70s)
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_Support_ds (193.62s)
=== CONT  TestAccRoute53TrafficPolicy_basic
--- PASS: TestAccRoute53TrafficPolicy_basic (10.90s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_Support_caa (182.34s)
=== CONT  TestAccRoute53ZoneDataSource_vpc
--- PASS: TestAccRoute53Record_Alias_changeDualstack (234.06s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_Alias_change (242.16s)
=== CONT  TestAccRoute53TrafficPolicyInstance_update
--- PASS: TestAccRoute53ZoneDataSource_vpc (148.42s)
=== CONT  TestAccRoute53ZoneDataSource_tags
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (252.25s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53ZoneDataSource_tags (141.03s)
=== CONT  TestAccRoute53ZoneDataSource_name
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (250.77s)
=== CONT  TestAccRoute53TrafficPolicyInstance_disappears
--- PASS: TestAccRoute53TrafficPolicyInstance_update (267.70s)
=== CONT  TestAccRoute53ZoneDataSource_id
--- PASS: TestAccRoute53ZoneDataSource_name (119.68s)
=== CONT  TestAccRoute53ZoneAssociation_crossAccountAndRegion
    zone_association_test.go:194: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccountAndRegion (0.00s)
=== CONT  TestAccRoute53Zone_VPC_single_forceDestroy
--- PASS: TestAccRoute53ZoneDataSource_id (94.25s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (267.99s)
=== CONT  TestAccRoute53Zone_VPC_updates
--- PASS: TestAccRoute53TrafficPolicyInstance_disappears (199.32s)
=== CONT  TestAccRoute53Zone_VPC_multiple
--- PASS: TestAccRoute53Zone_VPC_single_forceDestroy (200.24s)
=== CONT  TestAccRoute53Zone_VPC_single
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (236.62s)
=== CONT  TestAccRoute53Zone_tags
--- PASS: TestAccRoute53Zone_VPC_multiple (194.60s)
=== CONT  TestAccRoute53Zone_ForceDestroy_trailingPeriod
--- PASS: TestAccRoute53Zone_VPC_single (130.68s)
=== CONT  TestAccRoute53Zone_forceDestroy
--- PASS: TestAccRoute53Zone_VPC_updates (267.48s)
=== CONT  TestAccRoute53Zone_delegationSetID
--- PASS: TestAccRoute53Zone_tags (109.66s)
=== CONT  TestAccRoute53Zone_comment
--- PASS: TestAccRoute53Zone_delegationSetID (85.21s)
=== CONT  TestAccRoute53Zone_multiple
--- PASS: TestAccRoute53Zone_comment (135.95s)
=== CONT  TestAccRoute53Zone_disappears
--- PASS: TestAccRoute53Zone_multiple (107.93s)
=== CONT  TestAccRoute53Zone_basic
--- PASS: TestAccRoute53Zone_forceDestroy (250.49s)
=== CONT  TestAccRoute53TrafficPolicyInstance_basic
--- PASS: TestAccRoute53Zone_ForceDestroy_trailingPeriod (297.98s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Zone_disappears (100.22s)
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_complete
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_complete (7.51s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
--- PASS: TestAccRoute53Zone_basic (100.80s)
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_basic
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_basic (6.23s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
--- PASS: TestAccRoute53TrafficPolicyInstance_basic (192.65s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (218.48s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (264.67s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (256.45s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_Allow_overwrite (242.47s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (176.16s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (182.43s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (264.76s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (191.62s)
=== CONT  TestAccRoute53ZoneAssociation_disappears
--- PASS: TestAccRoute53Record_longTXTrecord (190.35s)
=== CONT  TestAccRoute53ZoneAssociation_crossAccount
    zone_association_test.go:132: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccount (0.00s)
=== CONT  TestAccRoute53HealthCheck_cloudWatchAlarmCheck
--- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (13.13s)
=== CONT  TestAccRoute53ZoneAssociation_Disappears_zone
--- PASS: TestAccRoute53Record_Support_txt (202.58s)
=== CONT  TestAccRoute53QueryLog_Disappears_hostedZone
    query_log_test.go:96: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53QueryLog_Disappears_hostedZone (0.00s)
=== CONT  TestAccRoute53ZoneAssociation_Disappears_vpc
--- PASS: TestAccRoute53Record_empty (172.54s)
=== CONT  TestAccRoute53QueryLog_disappears
    query_log_test.go:70: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53QueryLog_disappears (0.00s)
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53ZoneAssociation_Disappears_zone (192.96s)
=== CONT  TestAccRoute53QueryLog_basic
    query_log_test.go:38: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53QueryLog_basic (0.00s)
=== CONT  TestAccRoute53KeySigningKey_status
    key_signing_key_test.go:96: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53KeySigningKey_status (0.00s)
=== CONT  TestAccRoute53HealthCheck_basic
--- PASS: TestAccRoute53HealthCheck_basic (17.80s)
=== CONT  TestAccRoute53KeySigningKey_disappears
    key_signing_key_test.go:72: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53KeySigningKey_disappears (0.00s)
=== CONT  TestAccRoute53KeySigningKey_basic
    key_signing_key_test.go:31: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53KeySigningKey_basic (0.00s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_signingStatus
    hosted_zone_dnssec_test.go:82: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53HostedZoneDNSSEC_signingStatus (0.00s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_disappears
    hosted_zone_dnssec_test.go:58: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53HostedZoneDNSSEC_disappears (0.00s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_basic
    hosted_zone_dnssec_test.go:29: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53HostedZoneDNSSEC_basic (0.00s)
=== CONT  TestAccRoute53HealthCheck_disappears
--- PASS: TestAccRoute53ZoneAssociation_disappears (252.40s)
=== CONT  TestAccRoute53HealthCheck_withRoutingControlARN
--- PASS: TestAccRoute53HealthCheck_disappears (9.16s)
=== CONT  TestAccRoute53HealthCheck_disabled
--- PASS: TestAccRoute53HealthCheck_disabled (24.61s)
=== CONT  TestAccRoute53HealthCheck_withSNI
--- PASS: TestAccRoute53Record_fqdn (206.61s)
=== CONT  TestAccRoute53ZoneAssociation_basic
--- PASS: TestAccRoute53HealthCheck_withSNI (25.20s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (75.56s)
=== CONT  TestAccRoute53HealthCheck_withSearchString
--- PASS: TestAccRoute53HealthCheck_withSearchString (17.79s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53ZoneAssociation_Disappears_vpc (262.18s)
=== CONT  TestAccRoute53VPCAssociationAuthorization_crossRegion
    vpc_association_authorization_test.go:115: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53VPCAssociationAuthorization_crossRegion (0.00s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_underscored (191.15s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53ZoneAssociation_basic (250.44s)
=== CONT  TestAccRoute53VPCAssociationAuthorization_concurrent
    vpc_association_authorization_test.go:89: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53VPCAssociationAuthorization_concurrent (0.08s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (228.91s)
=== CONT  TestAccRoute53HealthCheck_tags
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (224.78s)
=== CONT  TestAccRoute53HealthCheck_ipv6
--- PASS: TestAccRoute53HealthCheck_ipv6 (14.54s)
=== CONT  TestAccRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccRoute53HealthCheck_tags (24.54s)
=== CONT  TestAccRoute53DelegationSet_basic
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (10.95s)
=== CONT  TestAccRoute53DelegationSet_disappears
--- PASS: TestAccRoute53DelegationSet_basic (10.92s)
=== CONT  TestAccRoute53HealthCheck_ip
--- PASS: TestAccRoute53DelegationSet_disappears (9.44s)
=== CONT  TestAccRoute53DelegationSet_withZones
--- PASS: TestAccRoute53HealthCheck_ip (17.95s)
=== CONT  TestAccRoute53CIDRCollection_disappears
--- PASS: TestAccRoute53CIDRCollection_disappears (10.05s)
=== CONT  TestAccRoute53ZoneDataSource_serviceDiscovery
--- PASS: TestAccRoute53Record_disappears (161.52s)
=== CONT  TestAccRoute53ZoneAssociation_crossRegion
--- PASS: TestAccRoute53DelegationSet_withZones (112.71s)
=== CONT  TestAccRoute53CIDRLocation_basic
--- PASS: TestAccRoute53CIDRLocation_basic (11.54s)
=== CONT  TestAccRoute53CIDRLocation_update
--- PASS: TestAccRoute53ZoneDataSource_serviceDiscovery (102.38s)
=== CONT  TestAccRoute53HealthCheck_withChildHealthChecks
--- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (12.05s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53CIDRLocation_update (19.07s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (232.38s)
--- PASS: TestAccRoute53ZoneAssociation_crossRegion (273.42s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (230.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	4028.806s
% AWS_DEFAULT_REGION=us-east-1 ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRoute53QueryLog_\|TestAccRoute53KeySigningKey_\|TestAccRoute53HostedZoneDNSSEC_' PKG=route53 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 4  -run=TestAccRoute53QueryLog_\|TestAccRoute53KeySigningKey_\|TestAccRoute53HostedZoneDNSSEC_ -timeout 720m
=== RUN   TestAccRoute53HostedZoneDNSSEC_basic
=== PAUSE TestAccRoute53HostedZoneDNSSEC_basic
=== RUN   TestAccRoute53HostedZoneDNSSEC_disappears
=== PAUSE TestAccRoute53HostedZoneDNSSEC_disappears
=== RUN   TestAccRoute53HostedZoneDNSSEC_signingStatus
=== PAUSE TestAccRoute53HostedZoneDNSSEC_signingStatus
=== RUN   TestAccRoute53KeySigningKey_basic
=== PAUSE TestAccRoute53KeySigningKey_basic
=== RUN   TestAccRoute53KeySigningKey_disappears
=== PAUSE TestAccRoute53KeySigningKey_disappears
=== RUN   TestAccRoute53KeySigningKey_status
=== PAUSE TestAccRoute53KeySigningKey_status
=== RUN   TestAccRoute53QueryLog_basic
=== PAUSE TestAccRoute53QueryLog_basic
=== RUN   TestAccRoute53QueryLog_disappears
=== PAUSE TestAccRoute53QueryLog_disappears
=== RUN   TestAccRoute53QueryLog_Disappears_hostedZone
=== PAUSE TestAccRoute53QueryLog_Disappears_hostedZone
=== CONT  TestAccRoute53HostedZoneDNSSEC_basic
=== CONT  TestAccRoute53KeySigningKey_status
=== CONT  TestAccRoute53KeySigningKey_basic
=== CONT  TestAccRoute53KeySigningKey_disappears
--- PASS: TestAccRoute53KeySigningKey_disappears (224.31s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_signingStatus
--- PASS: TestAccRoute53KeySigningKey_basic (240.82s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_disappears
--- PASS: TestAccRoute53KeySigningKey_status (304.18s)
=== CONT  TestAccRoute53QueryLog_disappears
--- PASS: TestAccRoute53HostedZoneDNSSEC_basic (341.79s)
=== CONT  TestAccRoute53QueryLog_Disappears_hostedZone
--- PASS: TestAccRoute53QueryLog_disappears (94.88s)
=== CONT  TestAccRoute53QueryLog_basic
--- PASS: TestAccRoute53QueryLog_Disappears_hostedZone (121.75s)
--- PASS: TestAccRoute53QueryLog_basic (123.59s)
--- PASS: TestAccRoute53HostedZoneDNSSEC_signingStatus (395.91s)
--- PASS: TestAccRoute53HostedZoneDNSSEC_disappears (362.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	607.625s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRoute53VPCAssociationAuthorization_\|TestAccRoute53ZoneAssociation_crossAccount' PKG=route53 ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 4  -run=TestAccRoute53VPCAssociationAuthorization_\|TestAccRoute53ZoneAssociation_crossAccount -timeout 720m
=== RUN   TestAccRoute53VPCAssociationAuthorization_basic
=== PAUSE TestAccRoute53VPCAssociationAuthorization_basic
=== RUN   TestAccRoute53VPCAssociationAuthorization_disappears
=== PAUSE TestAccRoute53VPCAssociationAuthorization_disappears
=== RUN   TestAccRoute53VPCAssociationAuthorization_concurrent
=== PAUSE TestAccRoute53VPCAssociationAuthorization_concurrent
=== RUN   TestAccRoute53VPCAssociationAuthorization_crossRegion
=== PAUSE TestAccRoute53VPCAssociationAuthorization_crossRegion
=== RUN   TestAccRoute53ZoneAssociation_crossAccount
=== PAUSE TestAccRoute53ZoneAssociation_crossAccount
=== RUN   TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53VPCAssociationAuthorization_basic
=== CONT  TestAccRoute53VPCAssociationAuthorization_crossRegion
=== CONT  TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53VPCAssociationAuthorization_concurrent
--- PASS: TestAccRoute53ZoneAssociation_crossAccountAndRegion (192.01s)
=== CONT  TestAccRoute53ZoneAssociation_crossAccount
--- PASS: TestAccRoute53VPCAssociationAuthorization_crossRegion (161.02s)
=== CONT  TestAccRoute53VPCAssociationAuthorization_disappears
--- PASS: TestAccRoute53VPCAssociationAuthorization_concurrent (162.04s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_basic (163.16s)
--- PASS: TestAccRoute53ZoneAssociation_crossAccount (186.05s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_disappears (146.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	312.175s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/ssm Issues and PRs that pertain to the ssm service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels May 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 14, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 15, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit
d/aws_route53_zone: Migrate to AWS SDK for Go v2.
c1a1144
@ewbankkit
r/aws_route53_record: Migrate to AWS SDK for Go v2.
acdb62c
@ewbankkit
r/aws_route53_cidr_location: Fix 'VPCAssociationAuthorizationNotFound…
ecd670e 
…: No authorization exists for hosted zone' on Delete.
@ewbankkit
route53: Migrate sweepers to AWS SDK for Go v2.
1e7d4c7
@ewbankkit
Fix semgrep 'ci.literal-value-string-constant'.
a135c4f
@ewbankkit
route53: Reduce visibility.
4203ac4
@ewbankkit
route53: Improve 'findResourceRecordSets'.
75c53e8
@ewbankkit
Fix semgrep 'ci.literal-0-string-test-constant' and 'ci.literal-1-str…
a8b26f0 
…ing-test-constant'.
@ewbankkit
Fix golangci-lint 'mnd'.
7a82d99
@ewbankkit
Fix golangci-lint 'nilerr'.
c03fd5f
@ewbankkit
Fix golangci-lint 'nolintlint'.
bde8880
@ewbankkit
r/aws_route53_cidr_collection: Fix 'NoSuchCidrCollectionException' on…
948dd62 
… Delete.
@ewbankkit
r/aws_route53_record: Fix 'TestAccRoute53Record_nameChange'.
9f7fd8f
@ewbankkit
d/aws_route53_zone: Remove extra sort of name servers.
2857760
@ewbankkit
r/aws_route53_key_signing_key: Fix 'NoSuchKeySigningKey' on Delete.
5621cb7
@ewbankkit
r/aws_route53_zone_association: AccessDenied errors likely due to cro…
c00beb4 
…ss-account issue.
@ewbankkit ewbankkit changed the title [WIP] Migrate route53 resources to AWS SDK for Go v2 Migrate route53 resources to AWS SDK for Go v2 May 20, 2024
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label May 20, 2024
@ewbankkit ewbankkit merged commit 2ad553c into main May 20, 2024
44 checks passed
@ewbankkit ewbankkit deleted the td-migrate-route53-to-aws-sdk-v2 branch May 20, 2024 15:39
@github-actions github-actions bot added this to the v5.51.0 milestone May 20, 2024
github-actions bot pushed a commit that referenced this pull request May 20, 2024
Update CHANGELOG.md for #37510
ba40b93
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced May 24, 2024
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/route53 Issues and PRs that pertain to the route53 service. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.51.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Route 53 Service
1 participant
@ewbankkit