stacks: update RPC APIs with deferral information #35125
Merged
+2,837
−1,662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving the components out of the main function definition so that we can reuse the implementation for deferred resource instances which wraps the message used for PlannedChangeResourceInstancePlanned
DanielMSchmidt
changed the title
alisdair
reviewed
Jun 3, 2024
| @@ -204,6 +206,79 @@ func LoadFromProto(msgs []*anypb.Any) (*Plan, error) { | |||
| c.ResourceInstancePriorState.Put(fullAddr, nil) | |||
| } | |||
|
|
|||
| case *tfstackdata1.PlanDeferredResourceInstanceChange: | |||
There was a problem hiding this comment.
There's a lot of overlap between this case and the planned change, which makes sense. Do you think there might be some way to unify them, maybe with helper functions? I'm a bit concerned about logic drift over time if the code is duplicated.
| @@ -277,18 +277,12 @@ func (pc *PlannedChangeResourceInstancePlanned) PlannedChangeProto() (*terraform | |||
| // if this plan later gets applied. | |||
| // We only emit a "raw" in this case, because this is a relatively | |||
| // uninteresting edge-case. | |||
There was a problem hiding this comment.
I'm not sure this comment fits here any more, although I am having some trouble with GitHub's diff of this file…
There was a problem hiding this comment.
Moved the comments around so they line up properly again.
alisdair
approved these changes
Jun 4, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds representation of deferred changes into the stacks RPC API. We create a new kind of planned change (a deferred resource) and emit that whenever we discover deferred changes from Terraform Core.