feat: refresh timeout #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
commented
May 14, 2024
| tenant := ctx.Value("tenant").(*dbsqlc.Tenant) | ||
| tenantId := sqlchelpers.UUIDToStr(tenant.ID) | ||
|
|
||
| stepRun, err := d.repo.StepRun().RefreshTimeoutAt(ctx, tenantId, request.StepRunId, request.IncrementTimeoutBy) |
There was a problem hiding this comment.
@abelanger5 is there a convenient way to validate the IncrementTimeoutBy string?
There was a problem hiding this comment.
Use the duration validator within RefreshTimeoutAt in an opts struct.
abelanger5
approved these changes
May 15, 2024
| tenant := ctx.Value("tenant").(*dbsqlc.Tenant) | ||
| tenantId := sqlchelpers.UUIDToStr(tenant.ID) | ||
|
|
||
| stepRun, err := d.repo.StepRun().RefreshTimeoutAt(ctx, tenantId, request.StepRunId, request.IncrementTimeoutBy) |
There was a problem hiding this comment.
Use the duration validator within RefreshTimeoutAt in an opts struct.
abelanger5
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Timeouts have been fixed intervals which does not afford flexibility during execution. Adds support to increase the timeout during step runtime.
Fixes HAT-121
Type of change
What's Changed