-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models to energy sites in Teslemetry #117419
Conversation
@@ -4,7 +4,7 @@ | |||
"id": 1234, | |||
"user_id": 1234, | |||
"vehicle_id": 1234, | |||
"vin": "VINVINVIN", | |||
"vin": "LRW3F7EK4KC700000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just change this back so we don't have a lot of unrelated changes in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the model value will be invalid, but thats probably okay as it will change again in another PR.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Bre77 👍
Proposed change
Adds model to the energy site devices, and then adds a test to snapshot the device registry. Also changes the VIN so that the vehicle device has an accurate model in those snapshots.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: