Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply all todoist custom project filters for calendar events #117454

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

boralyl
Copy link
Contributor

@boralyl boralyl commented May 14, 2024

Breaking change

Proposed change

This PR ensures that we apply all custom project filters when fetching calendar events. Prior to this PR we only filtered custom projects by the include_projects config parameter and not due_date_days or labels. https://www.home-assistant.io/integrations/todoist/#-----configuration-variables--

This caused the state of the custom project calendar to be correct based on the configured filters, but those filters were not all applied when viewing the calendar.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment on lines -628 to +632
or task.project_id in self._project_id_whitelist
task for task in tasks if self.create_todoist_task(task) is not None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering by the project_id_whitelist was moved into create_todoist_task where the other 2 filters are applied.

# If no ID is defined, fetch all tasks.
# If no ID is defined, this is a custom project.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR, but while investigating I wanted to make it clear what the value meant when it was None.

@boralyl boralyl marked this pull request as ready for review May 14, 2024 18:12
@MartinHjelmare MartinHjelmare changed the title Apply all custom project filters for calendar events. Apply all todoist custom project filters for calendar events May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label whitelist gets ignored in custom project
1 participant