-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data point type option to knx.telegram
trigger
#117463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
farmio
added
the
smash
Indicator this PR is close to finish for merging or closing
label
May 17, 2024
farmio
force-pushed
the
knx-telegram-trigger-dpt
branch
from
May 21, 2024 06:47
e291650
to
0a23d95
Compare
marvin-w
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me. Great addition!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
has-tests
integration: knx
new-feature
Quality Scale: platinum
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add data point type option to
knx.telegram
trigger so the trigger can decode data even if no project file data exists.This is also useful for blueprint creators - who can't know if the blueprint users have their project files parsed.
The
type
key accepts value type strings or numeric KNX-DPT-identifiers just likeknx.send
service or the sensor entity configuration do. If omitted (orNone
) and project file data is available, this data will be used to determine the type.The new interface for the trigger is
The change also makes it possible to use identity checks instead of dict-lookup-string-comparisons and we don't need to reparse the destination address for all telegrams.
Also
SignalType
is now used to have type safe dispatcher calls.Type of change
Additional information
knx.telegram
integration specific trigger; update KNX Interface device trigger #107592knx.telegram
trigger home-assistant.io#32782Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: