Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data point type option to knx.telegram trigger #117463

Merged
merged 7 commits into from
May 21, 2024
Merged

Conversation

farmio
Copy link
Contributor

@farmio farmio commented May 14, 2024

Proposed change

Add data point type option to knx.telegram trigger so the trigger can decode data even if no project file data exists.

This is also useful for blueprint creators - who can't know if the blueprint users have their project files parsed.

The type key accepts value type strings or numeric KNX-DPT-identifiers just like knx.send service or the sensor entity configuration do. If omitted (or None) and project file data is available, this data will be used to determine the type.

The new interface for the trigger is

trigger:
  - platform: knx.telegram
    destination:  # list of group addresses (optional - if omitted every telegram would fire the trigger)
      - "1/2/3"
    type: percent  # (optional - default: None)  <-- this is new
    group_value_write: true  # (optional - default: true)
    group_value_response: true  # (optional - default: true)
    group_value_read: true  # (optional - default: true)
    incoming: true  # (optional - default: true)
    outgoing: true  # (optional - default: true)

The change also makes it possible to use identity checks instead of dict-lookup-string-comparisons and we don't need to reparse the destination address for all telegrams.
Also SignalType is now used to have type safe dispatcher calls.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@farmio farmio added the smash Indicator this PR is close to finish for merging or closing label May 17, 2024
Copy link
Contributor

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. Great addition!

@marvin-w marvin-w merged commit 622d1e4 into dev May 21, 2024
24 checks passed
@marvin-w marvin-w deleted the knx-telegram-trigger-dpt branch May 21, 2024 22:03
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants