Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adext to 0.4.3 #117496

Merged
merged 1 commit into from
May 16, 2024
Merged

Bump adext to 0.4.3 #117496

merged 1 commit into from
May 16, 2024

Conversation

tichris0
Copy link
Contributor

@tichris0 tichris0 commented May 15, 2024

This updates the requirement for adext to 0.4.3 which adds functionality that paves the way for a follow-up PR that will make use of it.

changelog: ajschmidt8/adext@v0.4.2...v0.4.3

Proposed change

Bump up adext dependency for alarmdecoder from 0.4.2 to 0.4.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented May 15, 2024

Please add link to the changelog, or at minimum a diff between library versions is added to the PR description.

epenet
epenet previously requested changes May 15, 2024
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@home-assistant home-assistant bot marked this pull request as draft May 15, 2024 11:24
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet changed the title Update dependency on adext from 0.4.2 to 0.4.3 Bump adext to 0.4.3 May 15, 2024
@tichris0 tichris0 changed the title Bump adext to 0.4.3 Bump adext from 0.4.2 to 0.4.3 May 16, 2024
@tichris0
Copy link
Contributor Author

Please add link to the changelog, or at minimum a diff between library versions is added to the PR description.

I don't see any changelog for this library and the detailed description already had the library version diff. The summary line only had the end version and was missing the previous version so I've added that in the title.

@tichris0 tichris0 marked this pull request as ready for review May 16, 2024 07:31
@home-assistant home-assistant bot requested a review from epenet May 16, 2024 07:31
@epenet epenet changed the title Bump adext from 0.4.2 to 0.4.3 Bump adext to 0.4.3 May 16, 2024
@epenet
Copy link
Contributor

epenet commented May 16, 2024

It is the link that is missing in the detailed description.
See an example in #117383

@frenck
Copy link
Member

frenck commented May 16, 2024

and the detailed description already had the library version diff.

Sorry, I don't see such a link.

Could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

../Frenck

@frenck frenck marked this pull request as draft May 16, 2024 07:34
@tichris0
Copy link
Contributor Author

It is the link that is missing in the detailed description. See an example in #117383

Ahh perfect. That's super useful. I see thanks. I'll add that in.

@tichris0
Copy link
Contributor Author

and the detailed description already had the library version diff.

Sorry, I don't see such a link.

Could you please update the PR description to contain at least one (or multiple) of the following:

* A link to the release notes of this package version, and all versions in between.

* A link to the changelog of this package.

* A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

../Frenck

Yes makes sense, I wasn't sure how to do it in Github, but the example above made it clear :)

@tichris0 tichris0 marked this pull request as ready for review May 16, 2024 08:11
This updates the requirement for adext to 0.4.3 which adds functionality that paves the way for a follow-up PR that will make use of it.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tichris0 👍

../Frenck

@frenck frenck merged commit 2a540e1 into home-assistant:dev May 16, 2024
38 checks passed
aschmere pushed a commit to aschmere/hacore2 that referenced this pull request May 16, 2024
tr4nt0r pushed a commit to tr4nt0r/ha-core that referenced this pull request May 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants