-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump adext to 0.4.3 #117496
Bump adext to 0.4.3 #117496
Conversation
Please add link to the changelog, or at minimum a diff between library versions is added to the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I don't see any changelog for this library and the detailed description already had the library version diff. The summary line only had the end version and was missing the previous version so I've added that in the title. |
It is the link that is missing in the detailed description. |
Sorry, I don't see such a link. Could you please update the PR description to contain at least one (or multiple) of the following:
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant. Thanks already! 👍 ../Frenck |
Ahh perfect. That's super useful. I see thanks. I'll add that in. |
Yes makes sense, I wasn't sure how to do it in Github, but the example above made it clear :) |
This updates the requirement for adext to 0.4.3 which adds functionality that paves the way for a follow-up PR that will make use of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tichris0 👍
../Frenck
This updates the requirement for adext to 0.4.3 which adds functionality that paves the way for a follow-up PR that will make use of it.
changelog: ajschmidt8/adext@v0.4.2...v0.4.3
Proposed change
Bump up adext dependency for alarmdecoder from 0.4.2 to 0.4.3
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: