New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(context): infer TypedResponse
for TextRespond
#2579
Conversation
Thanks @yusukebe, that's great. But please wait a bit before merging, I found an untested regression, will document and add tests for it maybe tonight, urgent have to go now. |
@NamesMT Okay! |
Hi @yusukebe, I've done the updates to fix the regression and improve the type inferring for the The regression is: The final scope of work to get everything perfectly working was much bigger than I thought and I don't know if I did it the best way, so I will create a new draft PR for it to discuss if it's good or not. It's an un-splitted commit but heres the readable updates that I've made:
Bonus:
+ add new + update related tests New PR: #2581 |
Close to continue in #2581 |
Author should do the followings, if applicable
Add testsAdjusted testsyarn denoify
to generate files for Deno