Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Interceptor not saving selected option #4059

Open
1 task done
KyleOrth opened this issue May 13, 2024 · 3 comments
Open
1 task done

[bug]: Interceptor not saving selected option #4059

KyleOrth opened this issue May 13, 2024 · 3 comments
Labels
bug Something isn't working need testing Needs to be tested before merging onto production

Comments

@KyleOrth
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

As of #4051 the default interceptor has changed to Proxy instead of using the browser extension. This is affecting IP Addresses in requests being made.

Changing the setting back to Use browser extension resolves this issue. But after closing and reopening Hoppscotch, that setting is not saved and it reverts back to the Proxy, which is not working in my scenario.

Steps to reproduce

  1. Go to Settings
  2. Change Interceptor to Use the browser extension to send requests
  3. Send requests as needed
  4. Close and re-open Hoppscotch
  5. Observe settings has reverted back to using the Proxy again

Environment

Production

Version

Cloud

@KyleOrth KyleOrth added bug Something isn't working need testing Needs to be tested before merging onto production labels May 13, 2024
@thetronjohnson
Copy link
Member

hi @KyleOrth are you a logged-in user or are you using the app without an account?
I reproduced this and found that this issue is only present for non-logged in users, just wanted to confirm

@JulienPerrin
Copy link

JulienPerrin commented May 14, 2024

Hi,
I reproduce the issue on PWA.
When I open the app, the option "Use the browser extension to send requests (if present)" is no longer checked even though I checked it before.
Capture d’écran du 2024-05-14 09-31-36

To reproduce :

  1. check "Use the browser extension to send requests (if present)"
  2. close the PWA app, reopen it
  3. see that it is no longer checked.

@nivedin
Copy link
Member

nivedin commented May 14, 2024

@JulienPerrin @KyleOrth thank's for reporting the issue, it should be fixed with #4060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need testing Needs to be tested before merging onto production
Projects
None yet
Development

No branches or pull requests

4 participants