fix: persist interceptor state for logged out user #4060
+67
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivedin
requested review from
AndrewBastin,
amk-dev and
anwarulislam
as code owners
There was a problem hiding this comment.
The UI is inconsistent between the interceptor component and the rest of the settings page. The font is quite small and there is unnecessary left padding on the component. I think we can split the interceptor component into two, isolating just the radio buttons into a new component and reuse that for the settings page and interceptor popup.
JoelJacobStephen
requested changes
May 13, 2024
There was a problem hiding this comment.
@nivedin I noticed that the default interceptor is now set to None instead of Proxy when logged out. Is this intended?
1 task
JoelJacobStephen
approved these changes
May 14, 2024
nivedin
force-pushed
the
fix/default-interceptor-bug
branch
from
156b1cb
to
850954e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HFE-508 #4059
Description
This PR fixes the the bug where a logged out user's interceptor option did not get persisted while refreshing. Also added interceptor option in settings page.
Checks