Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable text streaming if user prefers reduced animation #1131

Merged
merged 4 commits into from
May 25, 2024

Conversation

neven4
Copy link
Contributor

@neven4 neven4 commented May 10, 2024

Disable the streaming updates when prefers-reduced-motion is set to reduce

Closes: #684

@neven4
Copy link
Contributor Author

neven4 commented May 13, 2024

Hi @nsarrazin, kindly requesting a review

@neven4
Copy link
Contributor Author

neven4 commented May 22, 2024

Hi @coyotte508, @gary149, @mishig25 maybe you could do a review?

@nsarrazin nsarrazin self-requested a review May 23, 2024 01:56
@nsarrazin
Copy link
Collaborator

Hi! Thanks for a great contrib 🔥 I took the liberty to push a commit that simplifies the way you filter stream updates in src/routes/conversation/[id]/+page.svelte

But overall it works great in local testing, if my fix still works for you then we can merge this! 🚀

@nsarrazin nsarrazin merged commit 0078ac2 into huggingface:main May 25, 2024
3 checks passed
@nsarrazin nsarrazin added enhancement New feature or request front This issue is related to the front-end of the app. labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front This issue is related to the front-end of the app.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable text streaming if user prefers reduced animation
2 participants