Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add doc for PixArtSigmaPipeline #7857

Merged
merged 25 commits into from
May 20, 2024
Merged

[docs] add doc for PixArtSigmaPipeline #7857

merged 25 commits into from
May 20, 2024
+160 −7

Conversation

lawrence-cj
Copy link
Contributor

What does this PR do?

This PR adds docs for PixArtSigmaPipeline.
Cc: @sayakpaul @yiyixuxu

@lawrence-cj
1. add doc for PixArtSigmaPipeline;
60326b0 
2. fix relative path bugs;
@lawrence-cj lawrence-cj changed the title 1. add doc for PixArtSigmaPipeline; 1. [docs] add doc for PixArtSigmaPipeline; May 4, 2024
@lawrence-cj lawrence-cj changed the title 1. [docs] add doc for PixArtSigmaPipeline; [docs] add doc for PixArtSigmaPipeline; May 4, 2024
@lawrence-cj lawrence-cj changed the title [docs] add doc for PixArtSigmaPipeline; [docs] add doc for PixArtSigmaPipeline May 4, 2024
sayakpaul
sayakpaul approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

stevhliu
stevhliu approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, remember to add the doc to the toctree!

docs/source/en/api/pipelines/pixart.md Show resolved Hide resolved
docs/source/en/api/pipelines/pixart_sigma.md Outdated Show resolved Hide resolved
docs/source/en/api/pipelines/pixart_sigma.md Outdated Show resolved Hide resolved
docs/source/en/api/pipelines/pixart_sigma.md Outdated Show resolved Hide resolved
lawrence-cj and others added 12 commits May 8, 2024 22:07
@lawrence-cj @sayakpaul
Update docs/source/en/api/pipelines/pixart_sigma.md
91e09b2 
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@lawrence-cj @stevhliu
Update docs/source/en/api/pipelines/pixart_sigma.md
d530101 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@lawrence-cj @stevhliu
Update docs/source/en/api/pipelines/pixart_sigma.md
d5f4c21 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@lawrence-cj @stevhliu
Update docs/source/en/api/pipelines/pixart_sigma.md
8a61ec3 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@glegendre01 @lawrence-cj
Ci - change cache folder (huggingface#7867)
d9e83ab
@stevhliu @lawrence-cj
[docs] Distilled inference (huggingface#7834)
b005ffe 
* combine

* edits
@asomoza @lawrence-cj
Fix for "no lora weight found module" with some loras (huggingface#7875)
1293bc1 
* return layer weight if not found

* better system and test

* key example and typo
@bghira @lawrence-cj
7879 - adjust documentation to use naruto dataset, since pokemon is n…
de84dec 
…ow gated (huggingface#7880)

* 7879 - adjust documentation to use naruto dataset, since pokemon is now gated

* replace references to pokemon in docs

* more references to pokemon replaced

* Japanese translation update

---------

Co-authored-by: bghira <bghira@users.github.com>
@HyoungwonCho @yiyixuxu @lawrence-cj
Modification on the PAG community pipeline (re) (huggingface#7876)
ae4a515 
* edited_pag_implementation

* update

---------

Co-authored-by: yiyixuxu <yixu310@gmail.com>
@tolgacangoz @yiyixuxu @lawrence-cj
Fix image upcasting (huggingface#7858)
85f28b3 
Fix image's upcasting before `vae.encode()` when using `fp16`

Co-authored-by: YiYi Xu <yixu310@gmail.com>
@ppham27 @lawrence-cj
Check shape and remove deprecated APIs in scheduling_ddpm_flax.py (hu…
2a76301 
…ggingface#7703)

`model_output.shape` may only have rank 1.

There are warnings related to use of random keys.

```
tests/schedulers/test_scheduler_flax.py: 13 warnings
  /Users/phillypham/diffusers/src/diffusers/schedulers/scheduling_ddpm_flax.py:268: FutureWarning: normal accepts a single key, but was given a key array of shape (1, 2) != (). Use jax.vmap for batching. In a future JAX version, this will be an error.
    noise = jax.random.normal(split_key, shape=model_output.shape, dtype=self.dtype)

tests/schedulers/test_scheduler_flax.py::FlaxDDPMSchedulerTest::test_betas
  /Users/phillypham/virtualenv/diffusers/lib/python3.9/site-packages/jax/_src/random.py:731: FutureWarning: uniform accepts a single key, but was given a key array of shape (1,) != (). Use jax.vmap for batching. In a future JAX version, this will be an error.
    u = uniform(key, shape, dtype, lo, hi)  # type: ignore[arg-type]
```
@lawrence-cj
Merge remote-tracking branch 'origin/main'
373d6e1
lawrence-cj and others added 4 commits May 9, 2024 04:07
@lawrence-cj @stevhliu
Update docs/source/en/api/pipelines/pixart_sigma.md
d20ccd6 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@lawrence-cj
fix the teaser image lin
66bca97
@lawrence-cj
Merge remote-tracking branch 'origin/main'
d30f940
@lawrence-cj @asomoza
Update docs/source/en/api/pipelines/pixart_sigma.md
a286f27 
Co-authored-by: Álvaro Somoza <asomoza@users.noreply.github.com>
yiyixuxu
yiyixuxu approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
also a note, can we change the type for scheduler to KarrasDiffusionSchedulers? this here indicates that sigma pipeline only works with DPM https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_sigma.py#L191C20-L191C47

docs/source/en/api/pipelines/pixart_sigma.md Show resolved Hide resolved
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented May 9, 2024

for the failing test, can you add the new doc page here?

https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/docs/source/en/_toctree.yml#L308

@lawrence-cj
Copy link
Contributor Author

thanks! also a note, can we change the type for scheduler to KarrasDiffusionSchedulers? this here indicates that sigma pipeline only works with DPM https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_sigma.py#L191C20-L191C47

Cool. Changed.

@lawrence-cj
Copy link
Contributor Author

for the failing test, can you add the new doc page here?

https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/docs/source/en/_toctree.yml#L308

Fixed all the request here. Cc: @sayakpaul @yiyixuxu

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul
sayakpaul approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I fixed the quality issues -- hope you don't mind.

@yiyixuxu good to merge?

@lawrence-cj
Copy link
Contributor Author

Gentle ping here. @yiyixuxu

yiyixuxu
yiyixuxu approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 0f0defd into huggingface:main May 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomoza asomoza asomoza left review comments

@stevhliu stevhliu stevhliu approved these changes

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet