Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI function calling compatible support #1888

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

phangiabao98
Copy link
Contributor

@phangiabao98 phangiabao98 commented May 14, 2024

What does this PR do?

Fixes # (issue)
#1887

Before submitting

  • [no ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [yes] Did you read the contributor guideline,
    Pull Request section?
  • [ yes] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [yes ] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • [ yes] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil

-->

@drbh
Copy link
Collaborator

drbh commented May 14, 2024

thanks for the contribution!

just opened another PR just to run CI #1894

@drbh
Copy link
Collaborator

drbh commented May 14, 2024

@phangiabao98 would you be able to run cargo fmt or pre-commit run --all-files and push another commit.

Once thats fixed I'll approve and merged. Thanks!

@phangiabao98
Copy link
Contributor Author

@drbh have just run cargo fmt and push another commit as your instruction.
2295f32

Please help to review and merge. Thanks !

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the surface.
Aren't we making a breaking change here changing the tool_id dtype ?

@phangiabao98
Copy link
Contributor Author

@Narsil I tested with python function call implementation as mention in #1887. Endpoint /chat/completion works fine.

Believe that the commits only impact on response of /chat/completion endpoint so other endpoint would not be impact.

Would you prefer adding this change into changelog ?

@Narsil
Copy link
Collaborator

Narsil commented May 16, 2024

Thanks !

@Narsil Narsil merged commit d8402ea into huggingface:main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants